Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: chrome/test/webdriver/automation.cc

Issue 6507015: Implement the target locator commands for ChromeDriver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: use bool success instead of handle != 0 Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/webdriver/automation.cc
diff --git a/chrome/test/webdriver/automation.cc b/chrome/test/webdriver/automation.cc
index eda6488638561cf566e199b6727494141ab4187e..5098662d9fa0b9ea82787d54b635a9e98b896619 100644
--- a/chrome/test/webdriver/automation.cc
+++ b/chrome/test/webdriver/automation.cc
@@ -37,16 +37,6 @@ void Automation::Init(bool* success) {
launch_arguments_.AppendSwitchPath(switches::kUserDataDir,
profile_dir_.path());
UITestBase::SetUp();
- browser_ = automation()->GetBrowserWindow(0);
- if (!browser_.get()) {
- Terminate();
- return;
- }
- tab_ = browser_->GetActiveTab();
- if (!tab_.get()) {
- Terminate();
- return;
- }
*success = true;
}
@@ -54,21 +44,49 @@ void Automation::Terminate() {
QuitBrowser();
}
-void Automation::ExecuteScript(const std::string& frame_xpath,
+void Automation::ExecuteScript(int tab_id,
+ const std::string& frame_xpath,
const std::string& script,
std::string* result,
bool* success) {
+ TabProxy* tab = GetTabById(tab_id);
+ if (!tab) {
+ *success = false;
+ return;
+ }
std::wstring wide_xpath = UTF8ToWide(frame_xpath);
std::wstring wide_script = UTF8ToWide(script);
std::wstring wide_result;
- *success = tab_->ExecuteAndExtractString(
+ *success = tab->ExecuteAndExtractString(
wide_xpath, wide_script, &wide_result);
if (*success)
*result = WideToUTF8(wide_result);
}
-void Automation::SendWebKeyEvent(const WebKeyEvent& key_event,
+void Automation::SendWebKeyEvent(int tab_id,
+ const WebKeyEvent& key_event,
bool* success) {
+ TabProxy* tab = GetTabById(tab_id);
+ if (!tab) {
+ *success = false;
+ return;
+ }
+ int tab_index = 0;
+ if (!tab->GetTabIndex(&tab_index)) {
+ *success = false;
+ return;
+ }
+ scoped_refptr<BrowserProxy> browser = tab->GetParentBrowser();
+ if (!browser.get()) {
+ LOG(ERROR) << "Could not get parent browser of tab";
+ *success = false;
+ return;
+ }
+ if (!browser->ActivateTab(tab_index)) {
+ LOG(ERROR) << "Could not activate tab to send keys";
+ *success = false;
+ return;
+ }
scoped_ptr<DictionaryValue> dict(new DictionaryValue);
dict->SetString("command", "SendKeyEventToActiveTab");
dict->SetInteger("type", key_event.type);
@@ -81,43 +99,129 @@ void Automation::SendWebKeyEvent(const WebKeyEvent& key_event,
std::string request;
base::JSONWriter::Write(dict.get(), false, &request);
std::string reply;
- *success = browser_->SendJSONRequest(request, &reply);
+ *success = browser->SendJSONRequest(request, &reply);
if (!*success) {
LOG(ERROR) << "Could not send web key event. Reply: " << reply;
}
}
-void Automation::NavigateToURL(const std::string& url,
+void Automation::NavigateToURL(int tab_id,
+ const std::string& url,
bool* success) {
- *success = tab_->NavigateToURL(GURL(url));
+ TabProxy* tab = GetTabById(tab_id);
+ if (!tab) {
+ *success = false;
+ return;
+ }
+ *success = tab->NavigateToURL(GURL(url));
}
-void Automation::GoForward(bool* success) {
- *success = tab_->GoForward();
+void Automation::GoForward(int tab_id, bool* success) {
+ TabProxy* tab = GetTabById(tab_id);
+ if (!tab) {
+ *success = false;
+ return;
+ }
+ *success = tab->GoForward();
}
-void Automation::GoBack(bool* success) {
- *success = tab_->GoBack();
+void Automation::GoBack(int tab_id, bool* success) {
+ TabProxy* tab = GetTabById(tab_id);
+ if (!tab) {
+ *success = false;
+ return;
+ }
+ *success = tab->GoBack();
}
-void Automation::Reload(bool* success) {
- *success = tab_->Reload();
+void Automation::Reload(int tab_id, bool* success) {
+ TabProxy* tab = GetTabById(tab_id);
+ if (!tab) {
+ *success = false;
+ return;
+ }
+ *success = tab->Reload();
}
-void Automation::GetURL(std::string* url,
+void Automation::GetURL(int tab_id,
+ std::string* url,
bool* success) {
+ TabProxy* tab = GetTabById(tab_id);
+ if (!tab) {
+ *success = false;
+ return;
+ }
GURL gurl;
- *success = tab_->GetCurrentURL(&gurl);
+ *success = tab->GetCurrentURL(&gurl);
if (*success)
*url = gurl.possibly_invalid_spec();
}
-void Automation::GetTabTitle(std::string* tab_title,
+void Automation::GetTabTitle(int tab_id,
+ std::string* tab_title,
bool* success) {
+ TabProxy* tab = GetTabById(tab_id);
+ if (!tab) {
+ *success = false;
+ return;
+ }
std::wstring wide_title;
- *success = tab_->GetTabTitle(&wide_title);
+ *success = tab->GetTabTitle(&wide_title);
if (*success)
*tab_title = WideToUTF8(wide_title);
}
+void Automation::GetTabIds(std::vector<int>* tab_ids,
+ bool* success) {
+ *success = false;
+ TabIdMap tab_id_map;
Jason Leyba 2011/02/15 23:59:26 Move this declaration down after GetBrowserWindowC
kkania 2013/02/28 21:49:38 Done.
+ int browser_count = 0;
+ if (!automation()->GetBrowserWindowCount(&browser_count)) {
+ LOG(ERROR) << "Failed to get browser window count";
+ return;
+ }
+ for (int browser_index = 0; browser_index < browser_count; ++browser_index) {
+ scoped_refptr<BrowserProxy> browser =
+ automation()->GetBrowserWindow(browser_index);
+ if (!browser.get())
+ continue;
+ int tab_count = 0;
+ if (!browser->GetTabCount(&tab_count))
+ continue;
+
+ for (int tab_index = 0; tab_index < tab_count; ++tab_index) {
+ scoped_refptr<TabProxy> tab = browser->GetTab(tab_index);
+ if (!tab.get())
+ continue;
+ tab_ids->push_back(tab->handle());
+ tab_id_map.insert(std::make_pair(tab->handle(), tab));
+ }
+ }
+
+ tab_id_map_ = tab_id_map;
+ *success = true;
+}
+
+void Automation::DoesTabExist(int tab_id, bool* does_exist) {
+ TabProxy* tab = GetTabById(tab_id);
+ *does_exist = tab && tab->is_valid();
+}
+
+void Automation::CloseTab(int tab_id, bool* success) {
+ TabProxy* tab = GetTabById(tab_id);
+ if (!tab) {
+ *success = false;
+ return;
+ }
+ *success = tab->Close(true);
+}
+
+TabProxy* Automation::GetTabById(int tab_id) {
+ TabIdMap::const_iterator iter = tab_id_map_.find(tab_id);
+ if (iter != tab_id_map_.end()) {
+ return iter->second.get();
+ }
+ return NULL;
+}
+
} // namespace webdriver

Powered by Google App Engine
This is Rietveld 408576698