chrome/test/webdriver/commands/session_with_id.cc - Issue 6507015: Implement the target locator commands for ChromeDriver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/webdriver/commands/session_with_id.cc

Issue 6507015: Implement the target locator commands for ChromeDriver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address Jason's concerns Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/webdriver/commands/session_with_id.cc

diff --git a/chrome/test/webdriver/commands/session_with_id.cc b/chrome/test/webdriver/commands/session_with_id.cc

index ed1614f15fca52baa2e309ac0848007d7e134739..a0af8b20d5f3e176453fe5b0fa991553b5b20f27 100644

--- a/chrome/test/webdriver/commands/session_with_id.cc

+++ b/chrome/test/webdriver/commands/session_with_id.cc

@@ -40,8 +40,8 @@ void SessionWithID::ExecuteGet(Response* const response) {

}

void SessionWithID::ExecuteDelete(Response* const response) {

+ // Session manages its own liftime, so do not call delete.

session_->Terminate();

- SessionManager::GetInstance()->Delete(session_->id());

response->set_status(kSuccess);

}