Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/common.gypi

Issue 6503001: clang: Fix several -Woverloaded-virtual warnings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/audio/linux/alsa_output_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 980a806fc7e4610097c605cc906be2934d584925..effdbfe90308589f738ca48dc81d1590fafa519c 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1213,8 +1213,6 @@
# http://code.google.com/p/googletest/source/detail?r=446 .
# TODO(thakis): Use -isystem instead (http://crbug.com/58751 )
'-Wno-unnamed-type-template-args',
- # TODO(thakis): Turn on -- http://crbug.com/72205
- '-Wno-overloaded-virtual',
],
'cflags!': [
# Clang doesn't seem to know know this flag.
@@ -1349,8 +1347,6 @@
# http://code.google.com/p/googletest/source/detail?r=446 .
# TODO(thakis): Use -isystem instead (http://crbug.com/58751 ).
'-Wno-unnamed-type-template-args',
- # TODO(thakis): Turn on -- http://crbug.com/72205
- '-Wno-overloaded-virtual',
],
}],
['clang==1 and clang_use_chrome_plugins==1', {
« no previous file with comments | « no previous file | media/audio/linux/alsa_output_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698