Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Side by Side Diff: build/common.gypi

Issue 6503001: clang: Fix several -Woverloaded-virtual warnings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | media/audio/linux/alsa_output_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 1195 matching lines...) Expand 10 before | Expand all | Expand 10 after
1206 ['_toolset=="target"', { 1206 ['_toolset=="target"', {
1207 'cflags': [ 1207 'cflags': [
1208 # Clang spots more unused functions. 1208 # Clang spots more unused functions.
1209 '-Wno-unused-function', 1209 '-Wno-unused-function',
1210 # Don't die on dtoa code that uses a char as an array index. 1210 # Don't die on dtoa code that uses a char as an array index.
1211 '-Wno-char-subscripts', 1211 '-Wno-char-subscripts',
1212 # Survive EXPECT_EQ(unnamed_enum, unsigned int) -- see 1212 # Survive EXPECT_EQ(unnamed_enum, unsigned int) -- see
1213 # http://code.google.com/p/googletest/source/detail?r=446 . 1213 # http://code.google.com/p/googletest/source/detail?r=446 .
1214 # TODO(thakis): Use -isystem instead (http://crbug.com/58751 ) 1214 # TODO(thakis): Use -isystem instead (http://crbug.com/58751 )
1215 '-Wno-unnamed-type-template-args', 1215 '-Wno-unnamed-type-template-args',
1216 # TODO(thakis): Turn on -- http://crbug.com/72205
1217 '-Wno-overloaded-virtual',
1218 ], 1216 ],
1219 'cflags!': [ 1217 'cflags!': [
1220 # Clang doesn't seem to know know this flag. 1218 # Clang doesn't seem to know know this flag.
1221 '-mfpmath=sse', 1219 '-mfpmath=sse',
1222 ], 1220 ],
1223 }]], 1221 }]],
1224 }], 1222 }],
1225 ['clang==1 and clang_use_chrome_plugins==1', { 1223 ['clang==1 and clang_use_chrome_plugins==1', {
1226 'target_conditions': [ 1224 'target_conditions': [
1227 ['_toolset=="target"', { 1225 ['_toolset=="target"', {
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
1342 'WARNING_CFLAGS': [ 1340 'WARNING_CFLAGS': [
1343 # Don't die on dtoa code that uses a char as an array index. 1341 # Don't die on dtoa code that uses a char as an array index.
1344 # This is required solely for base/third_party/dmg_fp/dtoa.cc. 1342 # This is required solely for base/third_party/dmg_fp/dtoa.cc.
1345 '-Wno-char-subscripts', 1343 '-Wno-char-subscripts',
1346 # Clang spots more unused functions. 1344 # Clang spots more unused functions.
1347 '-Wno-unused-function', 1345 '-Wno-unused-function',
1348 # Survive EXPECT_EQ(unnamed_enum, unsigned int) -- see 1346 # Survive EXPECT_EQ(unnamed_enum, unsigned int) -- see
1349 # http://code.google.com/p/googletest/source/detail?r=446 . 1347 # http://code.google.com/p/googletest/source/detail?r=446 .
1350 # TODO(thakis): Use -isystem instead (http://crbug.com/58751 ). 1348 # TODO(thakis): Use -isystem instead (http://crbug.com/58751 ).
1351 '-Wno-unnamed-type-template-args', 1349 '-Wno-unnamed-type-template-args',
1352 # TODO(thakis): Turn on -- http://crbug.com/72205
1353 '-Wno-overloaded-virtual',
1354 ], 1350 ],
1355 }], 1351 }],
1356 ['clang==1 and clang_use_chrome_plugins==1', { 1352 ['clang==1 and clang_use_chrome_plugins==1', {
1357 'OTHER_CFLAGS': [ 1353 'OTHER_CFLAGS': [
1358 '<(clang_chrome_plugins_flags)', 1354 '<(clang_chrome_plugins_flags)',
1359 ], 1355 ],
1360 }], 1356 }],
1361 ['clang==1 and clang_load!="" and clang_add_plugin!=""', { 1357 ['clang==1 and clang_load!="" and clang_add_plugin!=""', {
1362 'OTHER_CFLAGS': [ 1358 'OTHER_CFLAGS': [
1363 '-Xclang', '-load', '-Xclang', '<(clang_load)', 1359 '-Xclang', '-load', '-Xclang', '<(clang_load)',
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
1606 # and therefore SYMROOT, needs to be set at the project level. 1602 # and therefore SYMROOT, needs to be set at the project level.
1607 'SYMROOT': '<(DEPTH)/xcodebuild', 1603 'SYMROOT': '<(DEPTH)/xcodebuild',
1608 }, 1604 },
1609 } 1605 }
1610 1606
1611 # Local Variables: 1607 # Local Variables:
1612 # tab-width:2 1608 # tab-width:2
1613 # indent-tabs-mode:nil 1609 # indent-tabs-mode:nil
1614 # End: 1610 # End:
1615 # vim: set expandtab tabstop=2 shiftwidth=2: 1611 # vim: set expandtab tabstop=2 shiftwidth=2:
OLDNEW
« no previous file with comments | « no previous file | media/audio/linux/alsa_output_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698