Issue 650181: minor fixups to make this functional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 650181: minor fixups to make this functional (Closed)

Created:
10 years, 10 months ago by Sam Leffler

Modified:
9 years, 7 months ago

Reviewers:
kmixter1, ericli

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

minor fixups to make this functional - add --board option to find images - prompt before clobbering image unless --yes option specified (a la image_to_usb)

Patch Set 1 #

Total comments: 1

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -2 lines)			Patch
	M	src/scripts/mod_image_for_test.sh	View		2 chunks	+19 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sam Leffler

Perhaps should split the --yes change to a separate cl.

10 years, 10 months ago (2010-02-22 23:06:13 UTC) #1

ericli

10 years, 10 months ago (2010-02-22 23:25:48 UTC) #3

http://codereview.chromium.org/650181/diff/1/2
File src/scripts/mod_image_for_test.sh (right):

http://codereview.chromium.org/650181/diff/1/2#newcode13
src/scripts/mod_image_for_test.sh:13: DEFAULT_BOARD=x86-generic
DEFAULT_BOARD was already defined inside common.sh.

Expand Messages | Collapse Messages