Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: tools/presubmit.py

Issue 65017: - Exclude "build/include_what_you_use" from cpplint.py filters. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/presubmit.py
===================================================================
--- tools/presubmit.py (revision 1687)
+++ tools/presubmit.py (working copy)
@@ -35,6 +35,9 @@
import sys
import subprocess
+# Disabled LINT rules and reason.
+# build/include_what_you_use: Started giving false positives for variables
+# named "string" and "map" assuming that you needed to include STL headers.
ENABLED_LINT_RULES = """
build/class
@@ -42,7 +45,6 @@
build/endif_comment
build/forward_decl
build/include_order
-build/include_what_you_use
build/printf_format
build/storage_class
legal/copyright
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698