Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 650161: do not mention other browsers in about:memory for chromeos... (Closed)

Created:
10 years, 10 months ago by kuan
Modified:
7 years, 10 months ago
Reviewers:
sky, telizabethward
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

do not mention other browsers in about:memory for chromeos BUG=34839 TEST=verify per bug report Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39746

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/browser/browser_about_handler.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/defaults.h View 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/defaults.cc View 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/about_memory_linux.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
kuan
10 years, 10 months ago (2010-02-22 20:36:34 UTC) #1
sky
Can you move this into chrome/browser/defaults and name it something non-chromeos specific, perhaps kShowOtherBrowserInAboutMemory.
10 years, 10 months ago (2010-02-22 20:45:44 UTC) #2
kuan_google.com
should i use the bool all variants or just for linux? linux, windows and mac ...
10 years, 10 months ago (2010-02-22 20:55:37 UTC) #3
sky
You can scope it to just linux. -Scott On Mon, Feb 22, 2010 at 12:55 ...
10 years, 10 months ago (2010-02-22 21:03:35 UTC) #4
kuan
Done and uploaded snapshot. pls take another look. thanks. On 2010/02/22 21:03:35, sky wrote: > ...
10 years, 10 months ago (2010-02-22 21:29:17 UTC) #5
kuan
updated cl to use bool for all variants, pls take another look. thanks. On 2010/02/22 ...
10 years, 10 months ago (2010-02-23 17:27:38 UTC) #6
sky
LGTM with the following change. http://codereview.chromium.org/650161/diff/1005/2003 File chrome/browser/defaults.cc (right): http://codereview.chromium.org/650161/diff/1005/2003#newcode82 chrome/browser/defaults.cc:82: const bool kShowOtherBrowsersInAboutMemory = ...
10 years, 10 months ago (2010-02-23 18:13:38 UTC) #7
kuan
http://codereview.chromium.org/650161/diff/1005/2003 File chrome/browser/defaults.cc (right): http://codereview.chromium.org/650161/diff/1005/2003#newcode82 chrome/browser/defaults.cc:82: const bool kShowOtherBrowsersInAboutMemory = false; On 2010/02/23 18:13:38, sky ...
10 years, 10 months ago (2010-02-23 18:21:11 UTC) #8
telizabethward_gmail.com
7 years, 10 months ago (2013-01-29 10:19:53 UTC) #9
pardon my ignorance; i am trying to gather as much "evidence" against my 
hacker;
ex's new girlfriend. i first caught her intercepting emails and she she did 
them on the
public network at restaurant she works by learnig source code.(quickly, on 
my own)
she has been doing many many thins for over a month; removing software and 
private files,
 going on and chaning passwords to all of my email and ebay etc sites, 
locking me out 
of places, creating many ner users, floating annonomously, assining me a 
spam ip .....

well on google analyticts, she added memory for a bunch of other browsers i 
do not use 
on my samsung chromebook. i also have a toshibe satellite pc. i dont even 
know her name or phone #,
we have never met. no one takes me seriously that i know its one person 
because there is so much 
stuff. but i know her ip address (some of, she uses mine some times), i 
know my old ip , where my boyfriend still
lives, i have an old spamming phone number she used to use, and i know her 
st. address, but not the nubers.

sorry so long, but if she used the phrase that got me to yor pg., does that 
mean it would be wrong,
and noticably altered. i can probably find one of their identifiers, 
hopofully. any other advise for phrases in source
that are easy to connect/ there is an older ipod, aphone 4, ipad, older 
samsonite phone and  a laptop.



On Monday, February 22, 2010 3:36:35 PM UTC-5, Kuan Tan wrote:
>
> Reviewers: sky,
>
> Description:
> do not mention other browsers in about:memory for chromeos
>
> BUG=34839
> TEST=verfiy per bug report
>
>
> Please review this at http://codereview.chromium.org/650161
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>    M     chrome/browser/browser_about_handler.cc
>    M     chrome/browser/resources/about_memory_linux.html
>
>
> Index: chrome/browser/resources/about_memory_linux.html
> ===================================================================
> --- chrome/browser/resources/about_memory_linux.html        (revision 
> 39516)
> +++ chrome/browser/resources/about_memory_linux.html        (working copy)
> @@ -478,7 +478,7 @@
>             </td>
>           </tr>
>         </table>
> -      <div class=otherbrowsers jsdisplay="browsers.length == 1">
> +      <div class=otherbrowsers jsdisplay="!is_chrome_os && 
> browsers.length  
> == 1">
>           Note: If other browsers (e.g. IE, Firefox, Safari) are running,
>           I'll show their memory details here.
>         </div>
> Index: chrome/browser/browser_about_handler.cc
> ===================================================================
> --- chrome/browser/browser_about_handler.cc        (revision 39516)
> +++ chrome/browser/browser_about_handler.cc        (working copy)
> @@ -843,6 +843,12 @@
>         AppendProcess(child_data, &process.processes[index]);
>     }
>
> +#if defined(OS_CHROMEOS)
> +  root.SetBoolean(L"is_chrome_os", true);
> +#else
> +  root.SetBoolean(L"is_chrome_os", false);
> +#endif
> +
>     // Get about_memory.html
>     static const base::StringPiece memory_html(
>         ResourceBundle::GetSharedInstance().GetRawDataResource(
>
>
>

Powered by Google App Engine
This is Rietveld 408576698