Issue 650136: Declare register names as constants in assembler-x64.h. Fix for issue 615.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 650136: Declare register names as constants in assembler-x64.h. Fix for issue 615. (Closed)

Created:
10 years, 10 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Declare register names as constants in assembler-x64.h. Fix for issue 615. Committed: http://code.google.com/p/v8/source/detail?r=3924

Patch Set 1 #

Total comments: 5

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -102 lines)			Patch
M	src/x64/assembler-x64.h	View	2 chunks	+33 lines, -61 lines	3 comments	Download
M	src/x64/assembler-x64.cc	View	1 chunk	+0 lines, -40 lines	2 comments	Download
M	src/x64/macro-assembler-x64.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

Declare register names as constants. Fixes http://code.google.com/p/v8/issues/detail?id=615

10 years, 10 months ago (2010-02-22 10:33:59 UTC) #1

Lasse Reichstein

LGTM http://codereview.chromium.org/650136/diff/1/2 File src/x64/assembler-x64.cc (left): http://codereview.chromium.org/650136/diff/1/2#oldcode39 src/x64/assembler-x64.cc:39: Register rax = { 0 }; Are you ...

10 years, 10 months ago (2010-02-22 11:36:37 UTC) #2

William Hesse

10 years, 10 months ago (2010-02-22 11:41:08 UTC) #3

http://codereview.chromium.org/650136/diff/1/2
File src/x64/assembler-x64.cc (left):

http://codereview.chromium.org/650136/diff/1/2#oldcode39
src/x64/assembler-x64.cc:39: Register rax = { 0 };
On 2010/02/22 11:36:40, Lasse Reichstein wrote:
> Are you sure we shouldn't still have a definition here, just without the
value?

Yes.  Those weren't class static members, they were global variables.

http://codereview.chromium.org/650136/diff/1/4
File src/x64/assembler-x64.h (right):

http://codereview.chromium.org/650136/diff/1/4#newcode118
src/x64/assembler-x64.h:118: int code_;
On 2010/02/22 11:36:40, Lasse Reichstein wrote:
> Could we make it const?

The whole struct is const in all its accessors.  We are making it const by not
making it mutable.

Expand Messages | Collapse Messages