Make sbt support latest build workflow

Support renamed commands, remove non-portage build support, fix a minor mod_image_for_test bug.  Tested with build_autotest, mift, image_to_usb, and image_to_live.  Also not recreating the chroot unless it's missing or you pass --force_make_chroot as folks say that added dependencies in the chroot are handled currently during build_packages.

[sosa, 2010-02-23 20:01:47]

Some comments, nothing major :)

http://codereview.chromium.org/650123/diff/1001/2001
File src/scripts/mod_image_for_test.sh (right):

http://codereview.chromium.org/650123/diff/1001/2001#newcode26
src/scripts/mod_image_for_test.sh:26: echo "Here $IMAGES_DIR"
Debug?

http://codereview.chromium.org/650123/diff/1001/2002
File src/scripts/sync_build_test.sh (right):

http://codereview.chromium.org/650123/diff/1001/2002#newcode77
src/scripts/sync_build_test.sh:77: DEFINE_string board "x86-generic" "Board
setting"
You may also want to pass in chroot.  With the new build system it's kinda
common to have like 3

http://codereview.chromium.org/650123/diff/1001/2002#newcode80
src/scripts/sync_build_test.sh:80: DEFINE_integer build_jobs 1 "Concurrent build
jobs"
Why not use jobs to stay consistent?

http://codereview.chromium.org/650123/diff/1001/2002#newcode466
src/scripts/sync_build_test.sh:466: "--jobs=${FLAGS_build_jobs}"
Should make withdev explicit in case default changes

http://codereview.chromium.org/650123/diff/1001/2002#newcode470
src/scripts/sync_build_test.sh:470: if [[ '' ]]; then
Is this equivalent to true or false?

http://codereview.chromium.org/650123/diff/1001/2002#newcode484
src/scripts/sync_build_test.sh:484: "--board=${FLAGS_board}" --replace
You can pass jobs in here too and you prob. want to make withdev explicit in
case the default changes at some point

http://codereview.chromium.org/650123/diff/1001/2002#newcode487
src/scripts/sync_build_test.sh:487: board_param="--board=${FLAGS_board}"
You should declare this earlier and be consistent with its use in all script
params

[kmixter1, 2010-02-24 07:50:43]

Responded to all comments.  Your changes to MIFT superceded mine - the only diff
from your changes is to remove a trailing space.

http://codereview.chromium.org/650123/diff/1001/2001
File src/scripts/mod_image_for_test.sh (right):

http://codereview.chromium.org/650123/diff/1001/2001#newcode26
src/scripts/mod_image_for_test.sh:26: echo "Here $IMAGES_DIR"
On 2010/02/23 20:01:47, sosa wrote:
> Debug?

Done.

http://codereview.chromium.org/650123/diff/1001/2002
File src/scripts/sync_build_test.sh (right):

http://codereview.chromium.org/650123/diff/1001/2002#newcode77
src/scripts/sync_build_test.sh:77: DEFINE_string board "x86-generic" "Board
setting"
On 2010/02/23 20:01:47, sosa wrote:
> You may also want to pass in chroot.  With the new build system it's kinda
> common to have like 3

Done.

http://codereview.chromium.org/650123/diff/1001/2002#newcode80
src/scripts/sync_build_test.sh:80: DEFINE_integer build_jobs 1 "Concurrent build
jobs"
On 2010/02/23 20:01:47, sosa wrote:
> Why not use jobs to stay consistent?

Done.

http://codereview.chromium.org/650123/diff/1001/2002#newcode466
src/scripts/sync_build_test.sh:466: "--jobs=${FLAGS_build_jobs}"
On 2010/02/23 20:01:47, sosa wrote:
> Should make withdev explicit in case default changes

Done.

http://codereview.chromium.org/650123/diff/1001/2002#newcode470
src/scripts/sync_build_test.sh:470: if [[ '' ]]; then
On 2010/02/23 20:01:47, sosa wrote:
> Is this equivalent to true or false?

false

http://codereview.chromium.org/650123/diff/1001/2002#newcode484
src/scripts/sync_build_test.sh:484: "--board=${FLAGS_board}" --replace
On 2010/02/23 20:01:47, sosa wrote:
> You can pass jobs in here too and you prob. want to make withdev explicit in
> case the default changes at some point

Done.

http://codereview.chromium.org/650123/diff/1001/2002#newcode487
src/scripts/sync_build_test.sh:487: board_param="--board=${FLAGS_board}"
On 2010/02/23 20:01:47, sosa wrote:
> You should declare this earlier and be consistent with its use in all script
> params

Done.

[sosa, 2010-02-24 19:05:34]

lgtm.  my only response about the chroot is that i've occasionally gotten to the
point where i can't figure out what's wrong with something i changed in a host
setting and have had trouble getting back to a point where i'm sure that my
chroot is clean so I sometimes create a second chroot to test my theories or to
start over again.  i imagine this to be somewhat common while people transition

[seano, 2010-02-24 19:38:51]

LGTM