Issue 6501001: Fix a bug in git_cl/PRESUBMIT.py causing it to fail.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6501001: Fix a bug in git_cl/PRESUBMIT.py causing it to fail. (Closed)

Created:
9 years, 10 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Fix a bug in git_cl/PRESUBMIT.py causing it to fail. When I renamed setup_mock to local_rietveld, I had forgot one place in PRESUBMIT.py. TBR=evan BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74627

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	git_cl/PRESUBMIT.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

9 years, 10 months ago (2011-02-11 19:34:14 UTC) #2

LGTM

On Fri, Feb 11, 2011 at 9:54 AM,  <maruel@chromium.org> wrote:
> Reviewers: Evan Martin,
>
> Description:
> Fix a bug in git_cl/PRESUBMIT.py causing it to fail.
>
> When I renamed setup_mock to local_rietveld, I had forgot one place in
> PRESUBMIT.py.
>
> TBR=evan
> BUG=none
> TEST=none
>
> Please review this at http://codereview.chromium.org/6501001/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
>
> Affected files:
>  M git_cl/PRESUBMIT.py
>
>
> Index: git_cl/PRESUBMIT.py
> diff --git a/git_cl/PRESUBMIT.py b/git_cl/PRESUBMIT.py
> index
>
aaeafaf38b9e72359dabf6583ec3ac110d179f3b..8d2b16050bfcee9aca92de2b1d2df7a28a72f6d7
> 100644
> --- a/git_cl/PRESUBMIT.py
> +++ b/git_cl/PRESUBMIT.py
> @@ -63,7 +63,7 @@ def RunTests(input_api, output_api):
>       proc.communicate()
>       if proc.returncode != 0:
>         output.append(output_api.PresubmitError('%s failed' % test))
> -  except setup_mock.Failure, e:
> +  except local_rietveld.Failure, e:
>     output.append(output_api.PresubmitError('\n'.join(str(i) for i in
> e.args)))
>   finally:
>     server.stop_server()
>
>
>

Expand Messages | Collapse Messages