Include in 'backtrace' response scripts whose functions are on the stack

To resolve functions from the call stack we need at least ids for the scripts of those functions. The information on the scripts is now included into the response.

Committed: http://code.google.com/p/v8/source/detail?r=1708

[Søren Thygesen Gjesse, 2009-04-15 00:13:07]

LGTM

http://codereview.chromium.org/65006/diff/1/2
File src/mirror-delay.js (right):

http://codereview.chromium.org/65006/diff/1/2#newcode1718
Line 1718: // Add the handle for value mirrors.
Change comment to "Add mirror handle" (script mirror is not a value mirror).

http://codereview.chromium.org/65006/diff/1/2#newcode1778
Line 1778: if (mirror.id()) {
This if should not be needed as all scripts have id.

http://codereview.chromium.org/65006/diff/1/2#newcode1916
Line 1916: if (func.script()) {
Please just add the script directly to the frame serialization to keep the the
refs to be decendents of the serailized objects.

if (func.script()) {
  content.push(MakeJSONPair_('script',
this.serializeReference(mirror.func().script())));
}

If we add the source to the script serialization this might be to expensive...

[yurys, 2009-04-15 01:21:23]

http://codereview.chromium.org/65006/diff/1/2
File src/mirror-delay.js (right):

http://codereview.chromium.org/65006/diff/1/2#newcode1718
Line 1718: // Add the handle for value mirrors.
On 2009/04/15 00:13:07, Søren Gjesse wrote:
> Change comment to "Add mirror handle" (script mirror is not a value mirror).

Done.

http://codereview.chromium.org/65006/diff/1/2#newcode1778
Line 1778: if (mirror.id()) {
On 2009/04/15 00:13:07, Søren Gjesse wrote:
> This if should not be needed as all scripts have id.

Done.

http://codereview.chromium.org/65006/diff/1/2#newcode1916
Line 1916: if (func.script()) {
On 2009/04/15 00:13:07, Søren Gjesse wrote:
> Please just add the script directly to the frame serialization to keep the the
> refs to be decendents of the serailized objects.
> 
> if (func.script()) {
>   content.push(MakeJSONPair_('script',
> this.serializeReference(mirror.func().script())));
> }
> 
> If we add the source to the script serialization this might be to expensive...

Done.