Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1159)

Side by Side Diff: src/frames.h

Issue 65005: Added another check in SafeStackFrameIterator. (Closed)
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/frames.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 620 matching lines...) Expand 10 before | Expand all | Expand 10 after
631 void Reset(); 631 void Reset();
632 632
633 private: 633 private:
634 static bool IsWithinBounds( 634 static bool IsWithinBounds(
635 Address low_bound, Address high_bound, Address addr) { 635 Address low_bound, Address high_bound, Address addr) {
636 return low_bound <= addr && addr <= high_bound; 636 return low_bound <= addr && addr <= high_bound;
637 } 637 }
638 bool IsValidStackAddress(Address addr) const { 638 bool IsValidStackAddress(Address addr) const {
639 return IsWithinBounds(low_bound_, high_bound_, addr); 639 return IsWithinBounds(low_bound_, high_bound_, addr);
640 } 640 }
641 bool CanIterateHandles(StackFrame* frame, StackHandler* handler);
641 bool IsValidFrame(StackFrame* frame) const; 642 bool IsValidFrame(StackFrame* frame) const;
642 bool IsValidCaller(StackFrame* frame); 643 bool IsValidCaller(StackFrame* frame);
643 644
644 Address low_bound_; 645 Address low_bound_;
645 Address high_bound_; 646 Address high_bound_;
646 const bool is_valid_top_; 647 const bool is_valid_top_;
647 const bool is_valid_fp_; 648 const bool is_valid_fp_;
648 const bool is_working_iterator_; 649 const bool is_working_iterator_;
649 bool iteration_done_; 650 bool iteration_done_;
650 StackFrameIterator iterator_; 651 StackFrameIterator iterator_;
(...skipping 21 matching lines...) Expand all
672 JavaScriptFrame* FindJavaScriptFrame(int n); 673 JavaScriptFrame* FindJavaScriptFrame(int n);
673 674
674 private: 675 private:
675 StackFrameIterator iterator_; 676 StackFrameIterator iterator_;
676 }; 677 };
677 678
678 679
679 } } // namespace v8::internal 680 } } // namespace v8::internal
680 681
681 #endif // V8_FRAMES_H_ 682 #endif // V8_FRAMES_H_
OLDNEW
« no previous file with comments | « no previous file | src/frames.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698