Issue 650036: Land patch by Oleg Eterevsky (oleg@chromium.org).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 650036: Land patch by Oleg Eterevsky (oleg@chromium.org). (Closed)

Created:
10 years, 10 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Land patch by Oleg Eterevsky (oleg@chromium.org). Original review: http://codereview.chromium.org/646010/show Change the implementation of lastIndexOf method of String. Convert the strings in question to Vector<char> or Vector<uc16> and execute simple search algorithm on them. The difference in speed on 500k character string is about 10x. TBR=ager@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=3922

Patch Set 1 #

Total comments: 1

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -20 lines)			Patch
	M	src/runtime.cc	View		3 chunks	+76 lines, -20 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 10 months ago (2010-02-22 11:30:04 UTC) #2

LGTM

http://codereview.chromium.org/650036/diff/1/2
File src/runtime.cc (right):

http://codereview.chromium.org/650036/diff/1/2#newcode2506
src/runtime.cc:2506: HandleScope scope;  // create a new handle scope
Comment seems redundant here.

Expand Messages | Collapse Messages