Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Issue 650016: Solaris: WebKit patches to enable Solaris build. Specifically, /usr/bin/gcc i... (Closed)

Created:
10 years, 10 months ago by jchoi42
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

MOVED TO https://bugs.webkit.org/show_bug.cgi?id=35213 Thanks all. Solaris: WebKit patches to enable Solaris build. Specifically, /usr/bin/gcc is /usr/sfw/bin/gcc in SXCE and Opensolaris. I'm putting these changes as a seperate patch because it was suggested the preprocessor could be specified somewhere else, and /usr/bin/gcc wouldn't have to be hardcoded into the source. However, I'm not the expert at WebKit, so I'll leave it to someone more familiar to implement this. In the meantime, the following changes finish enabling Solaris Webkit build. BUG=30101 TEST=compiles Patch by James Choi <jchoi42@pha.jhu.edu>;

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -5 lines) Patch
M third_party/WebKit/WebCore/bindings/scripts/CodeGeneratorObjC.pm View 1 chunk +7 lines, -2 lines 0 comments Download
M third_party/WebKit/WebCore/bindings/scripts/IDLParser.pm View 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/WebCore/css/make-css-file-arrays.pl View 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/WebCore/dom/make_names.pl View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jchoi42
10 years, 10 months ago (2010-02-20 03:02:58 UTC) #1
Paweł Hajdan Jr.
I think these should go to WebKit (webkit.org). Looks OK at a glance.
10 years, 10 months ago (2010-02-20 17:31:18 UTC) #2
jchoi42
Done. https://bugs.webkit.org/show_bug.cgi?id=35213 Now we play the waiting game... On 2010/02/20 17:31:18, Paweł Hajdan Jr. wrote: ...
10 years, 10 months ago (2010-02-21 19:09:14 UTC) #3
Paweł Hajdan Jr.
10 years, 10 months ago (2010-02-21 19:37:47 UTC) #4
On 2010/02/21 19:09:14, jchoi42 wrote:
> Done. https://bugs.webkit.org/show_bug.cgi?id=35213
> 
> Now we play the waiting game...

Hopefully not. Read http://webkit.org/coding/contributing.html for some more
things to do. The ones I detected you haven't done yet are:

- creating a changelog entry
- setting the review? flag

Powered by Google App Engine
This is Rietveld 408576698