Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 6499014: ARM: Implement GetCachedArrayIndex in the lithium code generator. (Closed)

Created:
9 years, 10 months ago by Karl Klose
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

ARM: Implement GetCachedArrayIndex in the lithium code generator. Add GetCachedArrayIndex to the Hydrogen instruction set and implement GetCachedArrayIndex in the lithium code generator. The x64 and ia32 code generators implementations abort in the chunk builder.

Patch Set 1 #

Patch Set 2 : Fix bugs. #

Patch Set 3 : Fix bugs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -6 lines) Patch
M src/arm/lithium-arm.h View 2 chunks +12 lines, -0 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 3 chunks +15 lines, -5 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +12 lines, -0 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Karl Klose
9 years, 10 months ago (2011-02-15 14:34:32 UTC) #1
Søren Thygesen Gjesse
9 years, 10 months ago (2011-02-15 15:35:59 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698