Add access check when Object.keys is called on the global js proxy (fixes iss...

Add access check when Object.keys is called on the global js proxy (fixes issue 1154)

I will land access checks for a range of ES5 features in another patch (we added a bunch of cases like this in the past few weeks, i.e., cases where we simply use the global object instead of the js global proxy).



Committed: http://code.google.com/p/v8/source/detail?r=6786

[Mads Ager (chromium), 2011-02-15 08:56:10]

LGTM

http://codereview.chromium.org/6499013/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/6499013/diff/1/test/cctest/test-api.cc#newcode...
test/cctest/test-api.cc:5640: v8::HandleScope scope1;
No need for this since you have the handle scope above.

http://codereview.chromium.org/6499013/diff/1/test/cctest/test-api.cc#newcode...
test/cctest/test-api.cc:5648:
ExpectTrue("Object.keys(other).indexOf('blocked_prop')==-1");
Spaces around '=='.

[Rico, 2011-02-15 09:00:52]

http://codereview.chromium.org/6499013/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/6499013/diff/1/test/cctest/test-api.cc#newcode...
test/cctest/test-api.cc:5640: v8::HandleScope scope1;
On 2011/02/15 08:56:10, Mads Ager wrote:
> No need for this since you have the handle scope above.

Done.

http://codereview.chromium.org/6499013/diff/1/test/cctest/test-api.cc#newcode...
test/cctest/test-api.cc:5648:
ExpectTrue("Object.keys(other).indexOf('blocked_prop')==-1");
On 2011/02/15 08:56:10, Mads Ager wrote:
> Spaces around '=='.

Done.