Issue 6499003: Another intentional leak introduced by r74850

Issue 6499003: Another intentional leak introduced by r74850 (Closed)

Created:
9 years, 10 months ago by oshima

Modified:
9 years, 6 months ago

Reviewers:
awong

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Another intentional leak introduced by r74850 TBR=ajwong@chromium.org BUG=none TEST=heapcheck bot should cycle green Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74865

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	tools/heapcheck/suppressions.txt	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

awong

LGTM Doh...I didn't think this would cause any leaks. :( Sorry. On Mon, Feb 14, ...

9 years, 10 months ago (2011-02-14 23:34:49 UTC) #2

oshima

9 years, 10 months ago (2011-02-15 00:12:56 UTC) #3

Don't worry, this is intentional leak and no need for fix. I just wanted to
let you know.
You added nested object to leaking object, so that's reported as leak as
well :)

- oshima

On Mon, Feb 14, 2011 at 3:34 PM, Albert J. Wong (王重傑)
<ajwong@chromium.org>wrote:

> LGTM
>
> Doh...I didn't think this would cause any leaks. :(  Sorry.
>
>
> On Mon, Feb 14, 2011 at 2:50 PM, <oshima@chromium.org> wrote:
>
>> Reviewers: awong,
>>
>> Description:
>> Another intentional leak introduced by r74850
>>
>> TBR=ajwong@chromium.org
>> BUG=none
>> TEST=heapcheck bot should cycle green
>>
>> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74865
>>
>> Please review this at http://codereview.chromium.org/6499003/
>>
>> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>>
>> Affected files:
>>  M tools/heapcheck/suppressions.txt
>>
>>
>> Index: tools/heapcheck/suppressions.txt
>> diff --git a/tools/heapcheck/suppressions.txt
>> b/tools/heapcheck/suppressions.txt
>> index
>>
5a3e8795309b6e08c420960016c3d7ab0b605572..5c3a66db367d34748a096ceb61a48f77f1b55475
>> 100644
>> --- a/tools/heapcheck/suppressions.txt
>> +++ b/tools/heapcheck/suppressions.txt
>> @@ -135,6 +135,20 @@
>>    fun:testing::HandleExceptionsInMethodIfSupported
>>    fun:testing::Test::Run
>>  }
>> +{
>> +   Intentional leak in
>> BrowserThreadTest.NotReleasedIfTargetThreadNonExistent
>> +   Heapcheck:Leak
>> +   fun:RefCountedThreadSafeBase
>> +   fun:RefCountedThreadSafe
>> +   fun:NeverDeleted
>> +
>> fun:BrowserThreadTest_NotReleasedIfTargetThreadNonExistent_Test::TestBody
>> +   fun:testing::HandleExceptionsInMethodIfSupported
>> +   fun:testing::Test::Run
>> +   fun:testing::TestInfo::Run
>> +   fun:testing::TestCase::Run
>> +   fun:testing::internal::UnitTestImpl::RunAllTests
>> +   fun:testing::HandleExceptionsInMethodIfSupported
>> +}
>>  #-----------------------------------------------------------------------
>>  # 3. Suppressions for real chromium bugs that are not yet fixed.
>>  # These should all be in chromium's bug tracking system (but a few aren't
>> yet).
>>
>>
>>
>

Expand Messages | Collapse Messages