Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 6495: Change the font search order to try Lucida Sans Unicode before Arial Unicode ... (Closed)

Created:
12 years, 2 months ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
Nicolas Sylvain
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Change the font search order to try Lucida Sans Unicode before Arial Unicode MS because the former is available on Windows XP or later while the latter is only available with MS Office installed. This is partly to make font-dependent layout test results 'invariant' with or without Arial Unicode MS installed. Eventually, we may want to make those tests more robust against the font availability by removing some Unicode characters not commonly available. BUG=2304 TEST=pass the layout tests affected Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3062

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -253 lines) Patch
M base/gfx/font_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css2.1/t0805-c5518-brdr-t-01-e-expected.txt View 2 chunks +31 lines, -31 lines 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css2.1/t0805-c5519-brdr-r-00-a-expected.txt View 1 chunk +17 lines, -16 lines 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css2.1/t0805-c5520-brdr-b-01-e-expected.txt View 2 chunks +31 lines, -31 lines 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css2.1/t0805-c5521-brdr-l-00-a-expected.txt View 2 chunks +9 lines, -9 lines 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt View 2 chunks +13 lines, -13 lines 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css2.1/t0905-c414-flt-02-c-expected.txt View 1 chunk +20 lines, -20 lines 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css2.1/t0905-c414-flt-03-c-expected.txt View 1 chunk +20 lines, -20 lines 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css2.1/t0905-c414-flt-04-c-expected.txt View 1 chunk +28 lines, -28 lines 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css2.1/t0905-c5525-fltblck-01-d-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt View 2 chunks +5 lines, -5 lines 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css2.1/t0905-c5525-fltwrap-00-b-expected.txt View 2 chunks +6 lines, -6 lines 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css2.1/t090501-c414-flt-01-b-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css2.1/t090501-c414-flt-03-b-g-expected.txt View 1 chunk +9 lines, -9 lines 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css2.1/t090501-c414-flt-ln-01-d-g-expected.txt View 1 chunk +14 lines, -14 lines 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css2.1/t1205-c566-list-stl-01-c-g-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css2.1/t1503-c522-font-family-00-b-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css2.1/t1503-c522-font-family-00-b-expected.png View Binary file 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css2.1/t1503-c522-font-family-00-b-expected.txt View 3 chunks +21 lines, -21 lines 0 comments Download
M webkit/port/platform/graphics/FontCacheWin.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jungshik at Google
12 years, 2 months ago (2008-10-07 04:01:56 UTC) #1
Nicolas Sylvain
12 years, 2 months ago (2008-10-07 16:15:39 UTC) #2
LG

Powered by Google App Engine
This is Rietveld 408576698