chrome_frame/bho.cc - Issue 6493002: A number of poorly written IE BHO's crash IE if ChromeFrame is the currently ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_frame/bho.cc

Issue 6493002: A number of poorly written IE BHO's crash IE if ChromeFrame is the currently ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome_frame/bho.cc

===================================================================

--- chrome_frame/bho.cc (revision 74374)

+++ chrome_frame/bho.cc (working copy)

@@ -12,7 +12,7 @@

#include "base/string_util.h"

#include "base/stringprintf.h"

#include "base/win/scoped_bstr.h"

-#include "chrome_tab.h" // NOLINT

+#include "chrome_frame/buggy_bho_handling.h"

#include "chrome_frame/crash_reporting/crash_metrics.h"

#include "chrome_frame/extra_system_apis.h"

#include "chrome_frame/html_utils.h"

@@ -138,6 +138,10 @@

MetricsService::Start();

} else {

UnregisterThreadInstance();

+ buggy_bho::BuggyBhoTls::DestroyInstance();

+ ScopedComPtr<IWebBrowser2> web_browser2;

+ web_browser2.QueryFrom(m_spUnkSite);

+ DispEventUnadvise(web_browser2, &DIID_DWebBrowserEvents2);

tommi (sloooow) - chröme 2011/02/11 19:34:15 thanks :)

Release();

}

« no previous file with comments | « no previous file | chrome_frame/buggy_bho_handling.h » ('j') | chrome_frame/buggy_bho_handling.cc » ('J')