A number of poorly written IE BHO's crash IE if ChromeFrame is the currently ...

chrome_frame/utils.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome_frame/utils.h"
 
 #include <htiframe.h>
 #include <mshtml.h>
 #include <shlobj.h>
 
@@ skipping 15 matching lines @@
 #include "base/win/scoped_comptr.h"
 #include "base/win/scoped_variant.h"
 #include "chrome/common/chrome_paths_internal.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/installer/util/chrome_frame_distribution.h"
 #include "chrome_frame/extra_system_apis.h"
 #include "chrome_frame/html_utils.h"
 #include "chrome_frame/navigation_constraints.h"
 #include "chrome_frame/policy_settings.h"
 #include "chrome_frame/simple_resource_loader.h"
+#include "chrome_tab.h"  // NOLINT

[tommi (sloooow) - chröme, 2011/02/11 19:34:15]

move to the bottom? (plus an empty line before)

[ananta, 2011/02/11 21:19:35]

Done.

 #include "googleurl/src/gurl.h"
 #include "googleurl/src/url_canon.h"
 #include "grit/chromium_strings.h"
 #include "net/base/escape.h"
 #include "net/http/http_util.h"
 
 using base::win::RegKey;
 using base::win::ScopedComPtr;
 
 // Note that these values are all lower case and are compared to
@@ skipping 1530 matching lines @@
     ++url_list;
   }
 }
 
 std::wstring GetCurrentModuleVersion() {
   scoped_ptr<FileVersionInfo> module_version_info(
       FileVersionInfo::CreateFileVersionInfoForCurrentModule());
   DCHECK(module_version_info.get() != NULL);
   return module_version_info->file_version();
 }
+
+bool IsChromeFrameDocument(IWebBrowser2* web_browser) {
+  if (!web_browser)
+    return false;
+
+  ScopedComPtr<IDispatch> doc;
+  web_browser->get_Document(doc.Receive());
+  if (doc) {
+    // Detect if CF is rendering based on whether the document is a
+    // ChromeActiveDocument. Detecting based on hwnd is problematic as
+    // the CF Active Document window may not have been created yet.
+    ScopedComPtr<IChromeFrame> chrome_frame;
+    chrome_frame.QueryFrom(doc);
+    return !!chrome_frame.get();

[tommi (sloooow) - chröme, 2011/02/11 19:34:15]

instead of !! use
return chrome_frame.get() != NULL;
double negatives do sometimes not make any sense to nobody :)

[ananta, 2011/02/11 21:19:35]

Done.

+  }
+  return false;
+}
+