Port parts of base/process_util to Linux.

Port parts of base/process_util to Linux.

[please use my chromium address, 2008-10-06 11:35:07]

I know about post-webkit-merge work and closed tree. But I hope that things can
still be reviewed during this time.

This changeset will be needed for porting safe browsing database unit tests.

[please use my chromium address, 2008-10-08 10:32:05]

Tree is now open. Please take a look.

[Dean McNamee, 2008-10-08 11:24:26]

looks ok

http://codereview.chromium.org/6492/diff/1/2
File base/process_util_posix.cc (right):

http://codereview.chromium.org/6492/diff/1/2#newcode29
Line 29: // TODO(port): Get number of processors and put it into
processor_count_.
SysInfo::NumberOfProcessors ?

[please use my chromium address, 2008-10-08 16:09:31]

On 2008/10/08 11:24:26, Dean McNamee wrote:
> looks ok
> 
> http://codereview.chromium.org/6492/diff/1/2
> File base/process_util_posix.cc (right):
> 
> http://codereview.chromium.org/6492/diff/1/2#newcode29
> Line 29: // TODO(port): Get number of processors and put it into
> processor_count_.
> SysInfo::NumberOfProcessors ?

Done.

[sgk, 2008-10-08 16:13:47]

lgtm

[Evan Martin, 2008-10-13 22:04:06]

+estade, who has been working in the same area.

Evan, perhaps you can review this?

[Evan Stade, 2008-10-13 22:28:11]

I'd prefer to see constants pulled out as const variables, but I'm not sure if
this is the standard practice.

Otherwise LGTM.

http://codereview.chromium.org/6492/diff/203/208
File base/process_util_linux.cc (right):

http://codereview.chromium.org/6492/diff/203/208#newcode46
Line 46: if (last_key_name == "syscr") {
maybe pull these string literals out and store them in const char*s

[Evan Martin, 2008-10-13 23:13:04]

OK, I'll look into committing this.

[Evan Martin, 2008-10-14 00:21:42]

On 2008/10/13 23:13:04, Evan Martin wrote:
> OK, I'll look into committing this.

I ran out of time today, but I'll look again tomorrow.  (To handle the file
rename on Windows I'll need to update the vcproj file.)

[Evan Martin, 2008-10-14 20:49:56]

r3363