Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1628)

Side by Side Diff: src/codegen.h

Issue 6491: Refactor the arguments access code to make it easier to read. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/codegen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 339 matching lines...) Expand 10 before | Expand all | Expand 10 after
350 NEW_OBJECT 350 NEW_OBJECT
351 }; 351 };
352 352
353 explicit ArgumentsAccessStub(Type type) : type_(type) { } 353 explicit ArgumentsAccessStub(Type type) : type_(type) { }
354 354
355 private: 355 private:
356 Type type_; 356 Type type_;
357 357
358 Major MajorKey() { return ArgumentsAccess; } 358 Major MajorKey() { return ArgumentsAccess; }
359 int MinorKey() { return type_; } 359 int MinorKey() { return type_; }
360
360 void Generate(MacroAssembler* masm); 361 void Generate(MacroAssembler* masm);
362 void GenerateReadLength(MacroAssembler* masm);
363 void GenerateReadElement(MacroAssembler* masm);
364 void GenerateNewObject(MacroAssembler* masm);
361 365
362 const char* GetName() { return "ArgumentsAccessStub"; } 366 const char* GetName() { return "ArgumentsAccessStub"; }
363 367
364 #ifdef DEBUG 368 #ifdef DEBUG
365 void Print() { 369 void Print() {
366 PrintF("ArgumentsAccessStub (type %d)\n", type_); 370 PrintF("ArgumentsAccessStub (type %d)\n", type_);
367 } 371 }
368 #endif 372 #endif
369 }; 373 };
370 374
371 375
372 } // namespace internal 376 } // namespace internal
373 } // namespace v8 377 } // namespace v8
374 378
375 #endif // V8_CODEGEN_H_ 379 #endif // V8_CODEGEN_H_
OLDNEW
« no previous file with comments | « no previous file | src/codegen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698