Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: src/codegen.cc

Issue 6491: Refactor the arguments access code to make it easier to read. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/codegen.h ('k') | src/codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2007-2008 the V8 project authors. All rights reserved. 1 // Copyright 2007-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 344 matching lines...) Expand 10 before | Expand all | Expand 10 after
355 const char* RuntimeStub::GetName() { 355 const char* RuntimeStub::GetName() {
356 return Runtime::FunctionForId(id_)->stub_name; 356 return Runtime::FunctionForId(id_)->stub_name;
357 } 357 }
358 358
359 359
360 void RuntimeStub::Generate(MacroAssembler* masm) { 360 void RuntimeStub::Generate(MacroAssembler* masm) {
361 masm->TailCallRuntime(ExternalReference(id_), num_arguments_); 361 masm->TailCallRuntime(ExternalReference(id_), num_arguments_);
362 } 362 }
363 363
364 364
365 void ArgumentsAccessStub::Generate(MacroAssembler* masm) {
366 switch (type_) {
367 case READ_LENGTH: GenerateReadLength(masm); break;
368 case READ_ELEMENT: GenerateReadElement(masm); break;
369 case NEW_OBJECT: GenerateNewObject(masm); break;
370 }
371 }
372
373
365 } } // namespace v8::internal 374 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/codegen.h ('k') | src/codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698