Make the size of menulists on Linux the same size as on Windows.

Make the size of menulists on Linux the same size as on Windows.

We do this by adding an extra flag in MenuListExtraParams to
suppress the border in the same case that we don't draw it on
Windows.  We also change ButtonExtraParams because paintMenuList
calls into paintButton.

BUG=41729
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74986

[tony, 2011-02-11 00:56:28]

This is a 2 sided patch.  The webkit side is here:
https://bugs.webkit.org/show_bug.cgi?id=51152

[xiyuan, 2011-02-11 01:06:21]

http://codereview.chromium.org/6490014/diff/1/ui/gfx/native_theme_linux.cc
File ui/gfx/native_theme_linux.cc (right):

http://codereview.chromium.org/6490014/diff/1/ui/gfx/native_theme_linux.cc#ne...
ui/gfx/native_theme_linux.cc:505: skrect.set(rect.x() + 1, rect.y() + 1, kRight
- 1, kBottom - 1);
Should you set proper size for no border case so that it paints the whole rect?

[tony, 2011-02-11 18:06:10]

On 2011/02/11 01:06:21, xiyuan wrote:
> http://codereview.chromium.org/6490014/diff/1/ui/gfx/native_theme_linux.cc
> File ui/gfx/native_theme_linux.cc (right):
> 
>
http://codereview.chromium.org/6490014/diff/1/ui/gfx/native_theme_linux.cc#ne...
> ui/gfx/native_theme_linux.cc:505: skrect.set(rect.x() + 1, rect.y() + 1,
kRight
> - 1, kBottom - 1);
> Should you set proper size for no border case so that it paints the whole
rect?

Good idea.  I updated the code to fill the whole rect and not round the corners
if the border is set.

[xiyuan, 2011-02-11 18:09:55]

LGTM

[dgrogan, 2011-02-11 19:24:03]

On 2011/02/11 18:06:10, tony wrote:
> On 2011/02/11 01:06:21, xiyuan wrote:
> > http://codereview.chromium.org/6490014/diff/1/ui/gfx/native_theme_linux.cc
> > File ui/gfx/native_theme_linux.cc (right):
> > 
> >
>
http://codereview.chromium.org/6490014/diff/1/ui/gfx/native_theme_linux.cc#ne...
> > ui/gfx/native_theme_linux.cc:505: skrect.set(rect.x() + 1, rect.y() + 1,
> kRight
> > - 1, kBottom - 1);
> > Should you set proper size for no border case so that it paints the whole
> rect?
> 
> Good idea.  I updated the code to fill the whole rect and not round the
corners
> if the border is set.

Does that revision avoid the weird rounded corners that you can see at the
bottom of https://bug-51152-attachments.webkit.org/attachment.cgi?id=82149 ?

(Is there a way to upload attachments to http://codereview.chromium.org/ ?)

[xiyuan, 2011-02-11 19:29:19]

On 2011/02/11 19:24:03, dgrogan wrote:
> On 2011/02/11 18:06:10, tony wrote:
> > On 2011/02/11 01:06:21, xiyuan wrote:
> > > http://codereview.chromium.org/6490014/diff/1/ui/gfx/native_theme_linux.cc
> > > File ui/gfx/native_theme_linux.cc (right):
> > > 
> > >
> >
>
http://codereview.chromium.org/6490014/diff/1/ui/gfx/native_theme_linux.cc#ne...
> > > ui/gfx/native_theme_linux.cc:505: skrect.set(rect.x() + 1, rect.y() + 1,
> > kRight
> > > - 1, kBottom - 1);
> > > Should you set proper size for no border case so that it paints the whole
> > rect?
> > 
> > Good idea.  I updated the code to fill the whole rect and not round the
> corners
> > if the border is set.
> 
> Does that revision avoid the weird rounded corners that you can see at the
> bottom of https://bug-51152-attachments.webkit.org/attachment.cgi?id=82149 ?
> 
> (Is there a way to upload attachments to http://codereview.chromium.org/ ?)

Probably not. The corner radius does not look like from this code.

[tony, 2011-02-11 19:30:12]

Hmm, yes, I get the double border, although I'm not sure why.  I'll try to
figure out what's causing it and re-ping for a review.

I just use imgur.com to upload images.  *shrug*

[tony, 2011-02-11 23:34:30]

Updated to handle border radius.

[dgrogan.goog, 2011-02-12 02:39:59]

Mine doesn't count, but: LGTM.

[xiyuan, 2011-02-14 17:41:19]

LGTM

Ping me when this gets in and I'll update the ChromeOS part.