remoting/host/chromoting_host_context_unittest.cc - Issue 6489031: Run event executor on the ui thread to remove the need to explicitly XFlush() the XTest calls.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/host/chromoting_host_context_unittest.cc

Issue 6489031: Run event executor on the ui thread to remove the need to explicitly XFlush() the XTest calls. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Fixed glint warnings. Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « remoting/host/chromoting_host_context.cc ('k') | remoting/host/event_executor_linux.cc » ('j') | remoting/host/event_executor_linux.cc » ('J')

OLD	NEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/message_loop.h"	5 #include "base/message_loop.h"

6 #include "remoting/host/chromoting_host_context.h"	6 #include "remoting/host/chromoting_host_context.h"

7 #include "testing/gtest/include/gtest/gtest.h"	7 #include "testing/gtest/include/gtest/gtest.h"

8	8

9 namespace remoting {	9 namespace remoting {

10	10

11 // A simple test that starts and stop the context. This tests the context	11 // A simple test that starts and stop the context. This tests the context

12 // operates properly and all threads and message loops are valid.	12 // operates properly and all threads and message loops are valid.

13 TEST(ChromotingHostContextTest, StartAndStop) {	13 TEST(ChromotingHostContextTest, StartAndStop) {

14 ChromotingHostContext context;	14 ChromotingHostContext context(0);
	awong 2011/02/14 17:27:29 Please use NULL instead of 0. Please use NULL instead of 0. Jamie 2011/02/14 19:12:38 Done. Show quoted text On 2011/02/14 17:27:29, awong wrote: > Please use NULL instead of 0. Done.
15 context.Start();	15 context.Start();

16 EXPECT_TRUE(context.jingle_thread());	16 EXPECT_TRUE(context.jingle_thread());

17 EXPECT_TRUE(context.main_message_loop());	17 EXPECT_TRUE(context.main_message_loop());

18 EXPECT_TRUE(context.encode_message_loop());	18 EXPECT_TRUE(context.encode_message_loop());

19 context.Stop();	19 context.Stop();

20	20

21 // Expect all the threads are stopped.	21 // Expect all the threads are stopped.

22 EXPECT_FALSE(context.main_thread_.IsRunning());	22 EXPECT_FALSE(context.main_thread_.IsRunning());

23 EXPECT_FALSE(context.encode_thread_.IsRunning());	23 EXPECT_FALSE(context.encode_thread_.IsRunning());

24 }	24 }

25	25

26 } // namespace remoting	26 } // namespace remoting

OLD	NEW