Issue 6489027: Fix http://code.google.com/p/chromium/issues/detail?id=72555 incorrect...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6489027: Fix http://code.google.com/p/chromium/issues/detail?id=72555 incorrect... (Closed)

Created:
9 years, 10 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
floitschv8, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix http://code.google.com/p/chromium/issues/detail?id=72555 incorrect value for Math.LOG10E Committed: http://code.google.com/p/v8/source/detail?r=6753

Patch Set 1 #

Total comments: 2

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/math.js	View		2 chunks	+3 lines, -3 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 10 months ago (2011-02-11 11:06:57 UTC) #2

LGTM

http://codereview.chromium.org/6489027/diff/1/src/math.js
File src/math.js (right):

http://codereview.chromium.org/6489027/diff/1/src/math.js#newcode204
src/math.js:204: 2.718281828459045,
We could keep the extra digits on this one to match what is in the EcmaScript
spec.

http://codereview.chromium.org/6489027/diff/1/src/math.js#newcode227
src/math.js:227: 3.141592653589793,
Ditto.

Expand Messages | Collapse Messages