Issue 6489026: Whitelist RLE compression for ARM in bmpblk_utility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6489026: Whitelist RLE compression for ARM in bmpblk_utility (Closed)

Created:
9 years, 10 months ago by Tom Wai-Hong Tam

Modified:
9 years, 5 months ago

Reviewers:
Hung-Te, Bill Richardson

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
http://git.chromium.org/git/vboot_reference.git@master

Visibility:
Public.

Description

Whitelist RLE compression for ARM in bmpblk_utility BUG=chromium-os:11017 TEST=use RLE BMP files as input to run bmpblk_utility Change-Id: I2398d1c6cb9d5f90a85d8bfcab0af6e41a52b022 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a985ed4

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	utility/bmpblk_utility.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Hung-Te

LGTM with the CL itself (assuming the magic values are correct), however I'm not sure ...

9 years, 10 months ago (2011-02-11 10:09:12 UTC) #2

Bill Richardson

9 years, 10 months ago (2011-02-11 16:35:27 UTC) #3

LGTM. 

Since this is a command-line utility, I'd suggest that you add a warning message
if RLE compression is detected, so that whoever is running the program will know
that the BMPBLOCK they're generating won't work on x86. That can be done with a
separate CL if you want.

Expand Messages | Collapse Messages