Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 6489001: Change native RegExp call code to properly set C++ structures and (Closed)

Created:
9 years, 10 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
Søren Thygesen Gjesse, sgjesse
CC:
v8-dev
Visibility:
Public.

Description

Change native RegExp call code to properly set C++ structures and to handle exceptions on return from RegExp. BUG=1108 TEST= Committed: http://code.google.com/p/v8/source/detail?r=6794

Patch Set 1 #

Total comments: 1

Patch Set 2 : Ported to X64 and ARM. #

Patch Set 3 : Ob-lintfix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+536 lines, -372 lines) Patch
M src/arm/code-stubs-arm.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 7 chunks +49 lines, -109 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 2 chunks +10 lines, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 2 4 chunks +120 lines, -7 lines 0 comments Download
M src/arm/regexp-macro-assembler-arm.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/regexp-macro-assembler-arm.cc View 1 3 chunks +40 lines, -31 lines 0 comments Download
M src/arm/simulator-arm.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/code-stubs.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 5 chunks +28 lines, -79 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 1 chunk +91 lines, -0 lines 0 comments Download
M src/macro-assembler.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 8 chunks +84 lines, -139 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 1 chunk +90 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein
Please check for the viability of the approach. I'll do the same in X64 and ...
9 years, 10 months ago (2011-02-10 17:41:10 UTC) #1
Søren Thygesen Gjesse
LGTM http://codereview.chromium.org/6489001/diff/1/src/ia32/macro-assembler-ia32.h File src/ia32/macro-assembler-ia32.h (right): http://codereview.chromium.org/6489001/diff/1/src/ia32/macro-assembler-ia32.h#newcode309 src/ia32/macro-assembler-ia32.h:309: void Throw(); Throw -> Throw(Register object) for clarity?
9 years, 10 months ago (2011-02-11 08:18:53 UTC) #2
Lasse Reichstein
Addressed comments, ported to X64 and ARM.
9 years, 10 months ago (2011-02-15 12:56:40 UTC) #3
Søren Thygesen Gjesse
9 years, 10 months ago (2011-02-15 13:22:03 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698