brcmfmac: Fix suspend/resume

brcmfmac: Fix suspend/resume

Change-Id: I0754b3c54e90aa6808c052c9ff19ba1409e2bb24
Signed-off-by: Venkat Rao <vrao@broadcom.com>;
Signed-off-by: Grant Grundler <grundler@chromium.org>;

BUG=none
TEST=built/booted on tegra2_seabord. WIFI suspend/resume doesn't panic.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a5697c3

[Olof Johansson, 2011-03-08 02:35:23]

http://codereview.chromium.org/6488018/diff/1/drivers/staging/brcm80211/brcmf...
File drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c (right):

http://codereview.chromium.org/6488018/diff/1/drivers/staging/brcm80211/brcmf...
drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c:76: printk(KERN_ERR "%s:
Failed to set pm_flags 0x%08x\n",\
No need for \ at the end. It would be more interesting to print the actual error
code too (if it's propagated up).

http://codereview.chromium.org/6488018/diff/1/drivers/staging/brcm80211/brcmf...
drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c:77: __func__, (unsigned
int)flag);
No need to cast flag

[ggg, 2011-03-08 17:59:17]

Done. PTAL.

BTW, goal here is to submit these to gregkh drivers/staging ASAP. I'd like
Venkat to concentrate on fixing the remaining suspend/resume issues.

On 2011/03/08 02:35:23, Olof Johansson wrote:
>
http://codereview.chromium.org/6488018/diff/1/drivers/staging/brcm80211/brcmf...
> File drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c (right):
> 
>
http://codereview.chromium.org/6488018/diff/1/drivers/staging/brcm80211/brcmf...
> drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c:76: printk(KERN_ERR "%s:
> Failed to set pm_flags 0x%08x\n",\
> No need for \ at the end. It would be more interesting to print the actual
error
> code too (if it's propagated up).
> 
>
http://codereview.chromium.org/6488018/diff/1/drivers/staging/brcm80211/brcmf...
> drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c:77: __func__, (unsigned
> int)flag);
> No need to cast flag

[Olof Johansson, 2011-03-28 18:29:35]

I think you mentioned that the one going upstream might be a little different
from this patch. While I'm OK with that, it might make pulling in -staging
updates harder.

So, LGTM but please consider the alternative for your own sanity. :-)

[ggg, 2011-03-28 20:44:32]

On 2011/03/28 18:29:35, Olof Johansson wrote:
> I think you mentioned that the one going upstream might be
> a little different from this patch. While I'm OK with that,
> it might make pulling in -staging updates harder.

Not by much. I'll just drop revert this one since it will conflict with
upstream.

> 
> So, LGTM but please consider the alternative for your own sanity. :-)

np - thanks!
grant