Propagate the remote socket address to URLRequest and to ViewHostMsg_FrameNavigate.

net/url_request/url_request_ftp_job.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_ftp_job.h"
 
 #include "base/compiler_specific.h"
 #include "base/message_loop.h"
 #include "base/utf_string_conversions.h"
 #include "net/base/auth.h"
@@ skipping 34 matching lines @@
 }
 
 bool URLRequestFtpJob::GetMimeType(std::string* mime_type) const {
   if (transaction_->GetResponseInfo()->is_directory_listing) {
     *mime_type = "text/vnd.chromium.ftp-dir";
     return true;
   }
   return false;
 }
 
+std::string URLRequestFtpJob::GetSocketAddress() const {
+  if (!transaction_.get()) {

[Paweł Hajdan Jr., 2011/02/11 19:34:54]

It seems that other methods here assume transaction_ is non-NULL. Is this
NULL-check really needed?

[Brian Ryner, 2011/02/11 23:01:07]

I was trying to make sure it was safe to call GetSocketAddress() at any time,
such as before Start() is called, or after Kill() is called.

+    return "";
+  }
+
+  const FtpResponseInfo* response_info = transaction_->GetResponseInfo();
+  return response_info ? response_info->socket_address : "";

[Paweł Hajdan Jr., 2011/02/11 19:34:54]

Similarly here, do we need to NULL-check?

[Brian Ryner, 2011/02/11 23:01:07]

Here, probably not, it looks like GetResponseInfo() can never return NULL. 
Fixed.

+}
+
 URLRequestFtpJob::~URLRequestFtpJob() {
 }
 
 void URLRequestFtpJob::StartTransaction() {
   // Create a transaction.
   DCHECK(!transaction_.get());
   DCHECK(request_->context());
   DCHECK(request_->context()->ftp_transaction_factory());
 
   transaction_.reset(
@@ skipping 172 matching lines @@
   if (rv == ERR_IO_PENDING) {
     read_in_progress_ = true;
     SetStatus(URLRequestStatus(URLRequestStatus::IO_PENDING, 0));
   } else {
     NotifyDone(URLRequestStatus(URLRequestStatus::FAILED, rv));
   }
   return false;
 }
 
 }  // namespace net