Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Unified Diff: net/base/ssl_client_auth_cache_unittest.cc

Issue 6487012: Clear the SSL Client Auth cache when a new SSL Client Certificate is... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/ssl_client_auth_cache_unittest.cc
===================================================================
--- net/base/ssl_client_auth_cache_unittest.cc (revision 75583)
+++ net/base/ssl_client_auth_cache_unittest.cc (working copy)
@@ -137,4 +137,35 @@
EXPECT_EQ(NULL, cached_cert.get());
}
+// Check that the Clear() method removes all cache entries.
+TEST(SSLClientAuthCacheTest, Clear) {
+ SSLClientAuthCache cache;
+ base::Time start_date = base::Time::Now();
+ base::Time expiration_date = start_date + base::TimeDelta::FromDays(1);
+
+ std::string server1("foo:443");
+ scoped_refptr<X509Certificate> cert1(
+ new X509Certificate("foo", "CA", start_date, expiration_date));
+
+ cache.Add(server1, cert1);
+
+ std::string server2("foo2:443");
+ cache.Add(server2, NULL);
+
+ scoped_refptr<X509Certificate> cached_cert(cert1);
wtc 2011/02/23 00:38:38 Nit: cached_cert should not be initialized to cert
+
+ // Demonstrate the set up is correct.
+ EXPECT_TRUE(cache.Lookup(server1, &cached_cert));
+ EXPECT_EQ(cert1, cached_cert);
+
+ EXPECT_TRUE(cache.Lookup(server2, &cached_cert));
+ EXPECT_EQ(NULL, cached_cert.get());
+
+ cache.Clear();
+
+ // Check that we no longer have entries for either server.
+ EXPECT_FALSE(cache.Lookup(server1, &cached_cert));
+ EXPECT_FALSE(cache.Lookup(server2, &cached_cert));
+}
+
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698