Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6487001: Remember the appropriate previous directory when opening a select folder dial... (Closed)

Created:
9 years, 10 months ago by dmazzoni
Modified:
9 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Visibility:
Public.

Description

Remember the appropriate previous directory when opening a select folder dialog. BUG=72579 TEST=manual testing, trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75396

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/browser/ui/gtk/dialogs_gtk.cc View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dmazzoni
9 years, 10 months ago (2011-02-10 17:28:41 UTC) #1
Evan Stade
http://codereview.chromium.org/6487001/diff/1/chrome/browser/ui/gtk/dialogs_gtk.cc File chrome/browser/ui/gtk/dialogs_gtk.cc (right): http://codereview.chromium.org/6487001/diff/1/chrome/browser/ui/gtk/dialogs_gtk.cc#newcode313 chrome/browser/ui/gtk/dialogs_gtk.cc:313: *last_opened_path_ = path.DirName(); combine with the case above?
9 years, 10 months ago (2011-02-10 19:40:59 UTC) #2
dmazzoni
http://codereview.chromium.org/6487001/diff/1/chrome/browser/ui/gtk/dialogs_gtk.cc File chrome/browser/ui/gtk/dialogs_gtk.cc (right): http://codereview.chromium.org/6487001/diff/1/chrome/browser/ui/gtk/dialogs_gtk.cc#newcode313 chrome/browser/ui/gtk/dialogs_gtk.cc:313: *last_opened_path_ = path.DirName(); On 2011/02/10 19:41:00, Evan Stade wrote: ...
9 years, 10 months ago (2011-02-10 19:42:17 UTC) #3
Evan Stade
9 years, 10 months ago (2011-02-10 19:47:40 UTC) #4 
lgtm, thanks

Powered by Google App Engine
This is Rietveld 408576698