Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 6486034: Share PPAPI out-of-process plugins between renderer processes.... (Closed)

Created:
9 years, 10 months ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, Paweł Hajdan Jr., jam, apatrick_chromium, darin-cc_chromium.org, brettw-cc_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Share PPAPI out-of-process plugins between renderer processes. This provides the hook-up for plugin sharing but not shutdown or cleanup from errors. There is still a lot of work to do cleaning up in the plugin and the browser when a renderer dies, or cleaning up in the renderer and browser when a plugin dies. Currently, even the normal exit case crashes in the browser. But fixing it in this patch would be too complicated to write or review, so I'm going to do shutdown & error handling in a followup. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74766

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+487 lines, -292 lines) Patch
M chrome/browser/chrome_plugin_host.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/plugin_data_remover.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_service.h View 1 2 3 5 chunks +18 lines, -12 lines 0 comments Download
M chrome/browser/plugin_service.cc View 1 2 3 9 chunks +74 lines, -20 lines 0 comments Download
M chrome/browser/plugin_service_browsertest.cc View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ppapi_plugin_process_host.h View 1 2 3 2 chunks +41 lines, -13 lines 0 comments Download
M chrome/browser/ppapi_plugin_process_host.cc View 1 2 3 4 chunks +91 lines, -44 lines 0 comments Download
M chrome/browser/renderer_host/render_message_filter.h View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/render_message_filter.cc View 1 2 3 4 chunks +71 lines, -31 lines 0 comments Download
M chrome/ppapi_plugin/ppapi_thread.h View 1 2 3 2 chunks +15 lines, -21 lines 0 comments Download
M chrome/ppapi_plugin/ppapi_thread.cc View 1 2 3 4 chunks +50 lines, -51 lines 0 comments Download
M chrome/renderer/pepper_plugin_delegate_impl.cc View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 3 2 chunks +18 lines, -9 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_autogen.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/host_dispatcher.h View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
M ppapi/proxy/host_dispatcher.cc View 1 2 3 2 chunks +4 lines, -8 lines 0 comments Download
M ppapi/proxy/plugin_dispatcher.h View 1 2 3 5 chunks +22 lines, -8 lines 0 comments Download
M ppapi/proxy/plugin_dispatcher.cc View 1 2 3 8 chunks +49 lines, -27 lines 0 comments Download
M ppapi/proxy/ppapi_messages_internal.h View 1 2 3 2 chunks +12 lines, -11 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.cc View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
Note that a bunch of dates on generated GPU files changed because I had to ...
9 years, 10 months ago (2011-02-11 17:24:11 UTC) #1
brettw
9 years, 10 months ago (2011-02-13 17:50:36 UTC) #2
I'm TBRing this since I'm blocked on working on the proxy until this is in.
Please don't skip reviewing it.

Powered by Google App Engine
This is Rietveld 408576698