Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6485017: Carnitas: move browser/ui/shell_dialogs.{h,cc} to browser/ui (Closed)

Created:
9 years, 10 months ago by Evan Stade
Modified:
9 years, 6 months ago
CC:
chromium-reviews, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., davemoore+watch_chromium.org
Visibility:
Public.

Description

Carnitas: move browser/shell_dialogs.{h,cc} to browser/ui BUG=none TEST=compile Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74658

Patch Set 1 #

Patch Set 2 : lint #

Patch Set 3 : 2 more cases #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -41 lines) Patch
M chrome/browser/chromeos/options/wifi_config_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/net_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/options/advanced_options_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/options/certificate_manager_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/save_package.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_bookmarks_module.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extensions_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/file_select_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/file_select_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/shell_dialogs_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/certificate_dialogs.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/certificate_dialogs.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/dialogs_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/shell_dialogs.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/shell_dialogs.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/options/advanced_contents_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/fonts_page_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/fonts_page_view.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/options/languages_page_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/select_file_dialog.cc View 3 chunks +11 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/shell_dialogs_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/shell_dialogs_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/user_data_dir_dialog.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Stade
9 years, 10 months ago (2011-02-11 00:37:00 UTC) #1
Ben Goodger (Google)
9 years, 10 months ago (2011-02-11 00:41:50 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698