Issue 6484040: Revert 74103 - Use libjpeg-turbo by default....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6484040: Revert 74103 - Use libjpeg-turbo by default.... (Closed)

Created:
9 years, 10 months ago by jschuh

Modified:
9 years, 6 months ago

Reviewers:
Mark Mentovai, Craig, Hironori Bono

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 74103 - Use libjpeg-turbo by default. Switch 'use_libjpeg_turbo' flag back to 0 and revert valgrind suppressions from r74269. BUG=72399 BUG=48789 TEST=build Chromium without errors and pass all existing tests. Review URL: http://codereview.chromium.org/6332003 TBR=hbono@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74841

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -26 lines)			Patch
	M	build/common.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tools/valgrind/memcheck/suppressions.txt	View	1 2	1 chunk	+0 lines, -25 lines	0 comments	Download

Total messages: 6 (0 generated)

Mark Mentovai

Don’t change DEPS for this, just update build/common.gypi. LGTM with that change.

9 years, 10 months ago (2011-02-14 17:36:54 UTC) #2

jschuh

On 2011/02/14 17:36:54, Mark Mentovai wrote: > Don’t change DEPS for this, just update build/common.gypi. ...

9 years, 10 months ago (2011-02-14 17:52:10 UTC) #3

Craig

On 2011/02/14 17:36:54, Mark Mentovai wrote: > Don’t change DEPS for this, just update build/common.gypi. ...

9 years, 10 months ago (2011-02-14 17:52:44 UTC) #4

Mark Mentovai

You can back out r74269 in this change as far as I’m concerned. LGTM.

9 years, 10 months ago (2011-02-14 17:58:01 UTC) #5

Hironori Bono

9 years, 10 months ago (2011-02-15 01:29:02 UTC) #6

LGTM.
I will fix these memory issues as soon as possible.

Regards,

Hironori Bono