Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 6484023: Fix the semantics of delete on parameters. (Closed)

Created:
9 years, 10 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix the semantics of delete on parameters. Before, an attempt to delete a parameter in a function that used the arguments object in any way would succeed with true and delete both the parameter and the corresponding arguments object property. Now, an attempt to delete such a parameter does not delete and evaluates to false. Parameters can be deleted, as before, from functions that use the arguments object, by deleting the corresponding arguments object property (this is a spec violation). BUG=fixes v8:1136 Committed: http://code.google.com/p/v8/source/detail?r=6745

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -50 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +20 lines, -16 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +12 lines, -6 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +18 lines, -14 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +18 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
9 years, 10 months ago (2011-02-11 11:33:42 UTC) #1
Mads Ager (chromium)
9 years, 10 months ago (2011-02-11 11:39:29 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698