Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4837)

Unified Diff: chrome/browser/resources/options/autofill_edit_address_overlay.html

Issue 6484022: Autofill i18n: Set postal code and state field labels based on the selected country. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Still needs tests Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/autofill_edit_address_overlay.html
diff --git a/chrome/browser/resources/options/autofill_edit_address_overlay.html b/chrome/browser/resources/options/autofill_edit_address_overlay.html
index ba6696801af28ffc44fd392217aaa439e62df354..289e7b5e46ba89492ff392d13f76fb0161829df2 100644
--- a/chrome/browser/resources/options/autofill_edit_address_overlay.html
+++ b/chrome/browser/resources/options/autofill_edit_address_overlay.html
@@ -8,6 +8,12 @@
</label>
</div>
<div class="input">
dhollowa 2011/02/17 00:55:28 As discussed, country should follow other address
Ilya Sherman 2011/02/17 23:09:11 Done.
+ <label id="country-label">
+ <div><span i18n-content="country-label"></span></div>
+ <select id="country"></select>
+ </label>
+ </div>
+ <div class="input">
<label id="companyNameLabel">
dhollowa 2011/02/17 00:55:28 The new id and i18n-content values seem inconsiste
Ilya Sherman 2011/02/17 23:09:11 Hyphens, but James seemed to want to change the re
<div><span i18n-content="companyNameLabel"></span></div>
<input type="text" class="form" class="form" id="companyName">
@@ -33,14 +39,10 @@
</label>
</div>
<div class="input cell">
- <label id="stateLabel" for="state">
- <span i18n-content="stateLabel"></span>
- </label>
+ <label id="state-label" for="state"></label>
arv (Not doing code reviews) 2011/02/21 03:09:27 You should probably fix the other cases too or thi
Ilya Sherman 2011/02/23 01:17:15 Split out to http://codereview.chromium.org/655200
</div>
<div class="input cell">
- <label id="zipCodeLabel" for="zipCode">
- <span i18n-content="zipCodeLabel"></span>
- </label>
+ <label id="postal-code-label" for="postal-code"></label>
</div>
</div>
<div class="row">
@@ -51,16 +53,10 @@
<input type="text" class="form" id="state">
</div>
<div class="input cell">
- <input type="text" class="form" id="zipCode">
+ <input type="text" class="form" id="postal-code">
</div>
</div>
</div>
- <div class="input">
- <label id="countryLabel">
- <div><span i18n-content="countryLabel"></span></div>
- <input type="text" class="form" class="form" id="country">
- </label>
- </div>
<div class="table">
<div class="row">
<div class="input cell">

Powered by Google App Engine
This is Rietveld 408576698