Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: chrome/browser/resources/options/autofill_edit_address_overlay.html

Issue 6484022: Autofill i18n: Set postal code and state field labels based on the selected country. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: I see you, ICU Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/autofill_edit_address_overlay.html
diff --git a/chrome/browser/resources/options/autofill_edit_address_overlay.html b/chrome/browser/resources/options/autofill_edit_address_overlay.html
index ba6696801af28ffc44fd392217aaa439e62df354..bf47c7f00b474d5c8e8da7deb01e4237d765854c 100644
--- a/chrome/browser/resources/options/autofill_edit_address_overlay.html
+++ b/chrome/browser/resources/options/autofill_edit_address_overlay.html
@@ -2,6 +2,14 @@
<h1 id="autoFillAddressTitle"></h1>
<div class="content-area">
<div class="input">
James Hawkins 2011/02/12 20:32:45 Why are you moving the position of the country inp
Ilya Sherman 2011/02/16 10:27:18 Different countries have different address formats
+ <label id="countryLabel">
James Hawkins 2011/02/12 20:32:45 IDs use dash-form. I realize that this file is usi
Ilya Sherman 2011/02/16 10:27:18 Done.
+ <div><span i18n-content="countryLabel"></span></div>
+ <select id="country">
+ <option value=""></option>
James Hawkins 2011/02/12 20:32:45 It appears you're filling the select element in th
Ilya Sherman 2011/02/16 10:27:18 Done.
+ </select>
+ </label>
+ </div>
+ <div class="input">
<label id="fullNameLabel">
<div><span i18n-content="fullNameLabel"></span></div>
<input type="text" class="form" class="form" id="fullName">
@@ -38,8 +46,8 @@
</label>
</div>
<div class="input cell">
- <label id="zipCodeLabel" for="zipCode">
- <span i18n-content="zipCodeLabel"></span>
+ <label id="postalCodeLabel" for="postalCode">
James Hawkins 2011/02/12 20:32:45 dash-form ID
Ilya Sherman 2011/02/16 10:27:18 Done.
+ <span i18n-content="postalCodeLabel"></span>
</label>
</div>
</div>
@@ -51,16 +59,10 @@
<input type="text" class="form" id="state">
</div>
<div class="input cell">
- <input type="text" class="form" id="zipCode">
+ <input type="text" class="form" id="postalCode">
James Hawkins 2011/02/12 20:32:45 dash-form ID
Ilya Sherman 2011/02/16 10:27:18 Done.
</div>
</div>
</div>
- <div class="input">
- <label id="countryLabel">
- <div><span i18n-content="countryLabel"></span></div>
- <input type="text" class="form" class="form" id="country">
- </label>
- </div>
<div class="table">
<div class="row">
<div class="input cell">

Powered by Google App Engine
This is Rietveld 408576698