Issue 6484021: brcmfmac: Enabling flow control on uplink data direction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6484021: brcmfmac: Enabling flow control on uplink data direction (Closed)

Created:
9 years, 10 months ago by ggg

Modified:
9 years, 7 months ago

Reviewers:
Olof Johansson

CC:
chromium-os-reviews_chromium.org, vb+kernel_google.com, Mandeep Singh Baines

Base URL:
ssh://git@gitrw.chromium.org:9222/kernel-next.git@chromeos-2.6.37

Visibility:
Public.

Description

brcmfmac: Enable flow control on uplink data direction Change-Id: Ifd5713004b4b7d89bd6ae84c733da19c85ce4b78 Signed-off-by: Venkat Rao <vrao@broadcom.com>; BUG=none TEST=Broadcom Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=ce1f6f9

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	drivers/staging/brcm80211/brcmfmac/dhd_sdio.c	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Olof Johansson

Description looks inaccurate here -- it also seems to change the queue lengths. The patch ...

9 years, 9 months ago (2011-03-08 02:39:07 UTC) #1

ggg

9 years, 9 months ago (2011-03-09 02:10:00 UTC) #2

On Mon, Mar 7, 2011 at 6:39 PM,  <olofj@chromium.org> wrote:
> Description looks inaccurate here -- it also seems to change the queue
> lengths.
> The patch description should contain an explanation to why it was changed,
> please.

Agreed - let me find out why from Broadcom. It's not obvious from the code.

I'm also not happy with this patch. I'm going to remove dhd_doflow.

thanks,
grant

Expand Messages | Collapse Messages