Authenticate user/password with PAM in BeginSessionRequest()

remoting/host/user_auth_pam.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_HOST_USER_AUTH_PAM_H_
+#define REMOTING_HOST_USER_AUTH_PAM_H_
+
+#include <string>
+
+#include "base/basictypes.h"
+#include "base/scoped_ptr.h"
+#include "remoting/host/user_authenticator.h"
+
+namespace remoting {
+
+class UserAuthPamPimpl;
+
+// Class to perform a single PAM user authentication.
+// This object wraps a single PAM handle, so a separate instance should be
+// used for each authentication sequence (pam_start..pam_end).
+//
+// TODO(lambroslambrou): As pam_authenticate() can be blocking, this needs to
+// expose an asynchronous API, with pam_authenticate() called in a background
+// thread.
+class UserAuthPam : public UserAuthenticator {

[awong, 2011/02/15 01:05:28]

In one class, you use the "Auth" shorting, and in the other, you use
"Authenticator."  Make it consistent.

Call UserAuthenticatorPam?

+ public:
+  UserAuthPam();
+  virtual ~UserAuthPam();
+  virtual bool Authenticate(const std::string& username,
+                            const std::string& password);
+
+ private:
+  friend class UserAuthPamPimpl;

[awong, 2011/02/15 01:05:28]

Since this class is only for Pam, and we already have a hard interface in
UserAuthenticator, I don't think we need to additionally use a Pimpl pattern
here.  Merge UserAuthPamPimpl with UserAuthPam?

+  scoped_ptr<UserAuthPamPimpl> pimpl_;
+
+  DISALLOW_COPY_AND_ASSIGN(UserAuthPam);
+};
+
+}  // namespace remoting
+
+#endif  // REMOTING_HOST_USER_AUTH_PAM_H_