Authenticate user/password with PAM in BeginSessionRequest()

remoting/host/host_stub_fake.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/task.h"
 #include "remoting/host/chromoting_host.h"
 #include "remoting/host/host_stub_fake.h"
 #include "remoting/proto/auth.pb.h"
 #include "remoting/protocol/client_stub.h"
 #include "remoting/protocol/connection_to_client.h"
 
+#if defined(OS_LINUX)
+#include "remoting/host/user_auth_pam.h"
+#endif
+
 namespace remoting {
 
 HostStubFake::HostStubFake(ChromotingHost* host)
     : host_(host) {
 }
 
 void HostStubFake::SuggestResolution(
     const protocol::SuggestResolutionRequest* msg, Task* done) {
   done->Run();
   delete done;
 }
 
 void HostStubFake::BeginSessionRequest(
     const protocol::LocalLoginCredentials* credentials, Task* done) {
+  protocol::LocalLoginStatus* status = new protocol::LocalLoginStatus();

[Sergey Ulanov, 2011/02/10 20:14:28]

We shouldn't add pam auth in HostStubFake. It is fake, and shouldn't do any real
auth. I think we need host_stub_<platform>.cc which will be platform specific.
This can be done in a separate CL - up to you.

+  bool success = false;
+  switch (credentials->type()) {
+    case protocol::PASSWORD:
+#if defined(OS_LINUX)
+      success = UserAuthPam().Authenticate(credentials->username(),
+                                           credentials->credential());
+#else
+      // TODO(lambroslambrou): implement on other platforms
+      success = true;
+#endif  // defined(OS_LINUX)
+      break;
+    default:
+      break;
+  }
+  status->set_success(success);
+  host_->connection_to_client()->client_stub()->BeginSessionResponse(
+      status, new DeleteTask<protocol::LocalLoginStatus>(status));
+  if (success) {
+    host_->LocalLoginSucceeded();
+  } else {
+    // ???

[Sergey Ulanov, 2011/02/10 20:14:28]

I think it should be enough to log the failure here:
 LOG(ERROR) << "Login failed for user " << username;

+  }
   done->Run();
   delete done;
-
-  protocol::LocalLoginStatus* status = new protocol::LocalLoginStatus();
-  status->set_success(true);
-  host_->connection_to_client()->client_stub()->BeginSessionResponse(
-      status, new DeleteTask<protocol::LocalLoginStatus>(status));
-  host_->LocalLoginSucceeded();
 }
 
 }  // namespace remoting