src/ast.cc - Issue 6483010: Check holder before optimizing calls to global functions....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast.cc

Issue 6483010: Check holder before optimizing calls to global functions.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ast.cc

===================================================================

--- src/ast.cc (revision 6724)

+++ src/ast.cc (working copy)

@@ -618,7 +618,9 @@

cell_ = Handle<JSGlobalPropertyCell>::null();

LookupResult lookup;

global->Lookup(*name, &lookup);

- if (lookup.IsProperty() && lookup.type() == NORMAL) {

+ if (lookup.IsProperty() &&

+ lookup.type() == NORMAL &&

+ lookup.holder() == *global) {

cell_ = Handle<JSGlobalPropertyCell>(global->GetPropertyCell(&lookup));

if (cell_->value()->IsJSFunction()) {

Handle<JSFunction> candidate(JSFunction::cast(cell_->value()));

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-1106.js » ('j') | no next file with comments »