Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: base/logging.cc

Issue 6482013: Mac: Don't show dialogs for debug messages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: '' Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/logging.cc
diff --git a/base/logging.cc b/base/logging.cc
index 0a808b4524c62a7f13a1c63d7eef79aaae3c5933..e36a168bb12e965e7c7225e644d41c28e6002bc5 100644
--- a/base/logging.cc
+++ b/base/logging.cc
@@ -14,7 +14,6 @@ typedef HANDLE MutexHandle;
// Windows doesn't define STDERR_FILENO. Define it here.
#define STDERR_FILENO 2
#elif defined(OS_MACOSX)
-#include <CoreFoundation/CoreFoundation.h>
#include <mach/mach.h>
#include <mach/mach_time.h>
#include <mach-o/dyld.h>
@@ -57,10 +56,6 @@ typedef pthread_mutex_t* MutexHandle;
#if defined(OS_POSIX)
#include "base/safe_strerror_posix.h"
#endif
-#if defined(OS_MACOSX)
-#include "base/mac/scoped_cftyperef.h"
-#include "base/sys_string_conversions.h"
-#endif
namespace logging {
@@ -503,12 +498,6 @@ void DisplayDebugMessageInDialog(const std::string& str) {
MessageBoxW(NULL, &cmdline[0], L"Fatal error",
MB_OK | MB_ICONHAND | MB_TOPMOST);
}
-#elif defined(OS_MACOSX)
- base::mac::ScopedCFTypeRef<CFStringRef> message(
- base::SysUTF8ToCFStringRef(str));
- CFUserNotificationDisplayNotice(0, kCFUserNotificationStopAlertLevel,
- NULL, NULL, NULL, CFSTR("Fatal Error"),
- message, NULL);
#else
// We intentionally don't implement a dialog on other platforms.
// You can just look at stderr.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698