Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 6482013: Mac: Don't show dialogs for debug messages. (Closed)

Created:
9 years, 10 months ago by Nico
Modified:
9 years, 7 months ago
Reviewers:
dmac
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Mac: Don't show dialogs for debug messages. They're printed to stderr, and the dialogs are often too high to fit on a (30'') screen. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75765

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M base/logging.cc View 1 3 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
9 years, 10 months ago (2011-02-10 02:09:27 UTC) #1
dmac
On 2011/02/10 02:09:27, Nico wrote: Just to be clear, what is the problem you are ...
9 years, 10 months ago (2011-02-10 04:27:08 UTC) #2
Nico
Several problems: * The stacks are usually to wide for the message box, so that ...
9 years, 10 months ago (2011-02-18 23:01:26 UTC) #3
dmac
9 years, 10 months ago (2011-02-23 04:50:02 UTC) #4
On 2011/02/18 23:01:26, Nico wrote:
> Several problems:
> 
> * The stacks are usually to wide for the message box, so that the message box
> contains ugly line breaks
> * The stacks are often deep, making the text higher than what fits in the
> message box (mostly on my 15' mbp)
> * Since DCHECKs terminate the app, "Seeing a DCHECK fly by on stderr" isn't
> really what happens – it will be the last thing that's printed on stderr.
> 
> I always have to click away the message box since it's unreadable and then
look
> at stderr. I'd rather only look at stderr.

LGTM

Powered by Google App Engine
This is Rietveld 408576698