Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: tests/bitmaps/TestBmpBlock.py

Issue 6482001: New commandline args are clearer, and prepare for compression. (Closed) Base URL: http://git.chromium.org/git/vboot_reference.git@master
Patch Set: Move bmpblk_util.h out of firmware/include Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/bitmaps/TestBmpBlock.py
diff --git a/tests/bitmaps/TestBmpBlock.py b/tests/bitmaps/TestBmpBlock.py
index 9abe72df63897d1ba8a5d222af5ad814c0dc893b..2f83e1ef680e79e79ff630e254650d49d341057c 100755
--- a/tests/bitmaps/TestBmpBlock.py
+++ b/tests/bitmaps/TestBmpBlock.py
@@ -21,17 +21,18 @@ class TestBmpBlock(unittest.TestCase):
"""Running with no args should print usage and fail."""
rc, out, err = runprog(prog)
self.assertNotEqual(0, rc)
- self.assertTrue(out.count("Usage:"))
+ self.assertTrue(err.count("missing BMPBLOCK name"))
+ self.assertTrue(out.count("bmpblk_utility"))
def testMissingBmp(self):
"""Missing a bmp specified in the yaml is an error."""
- rc, out, err = runprog(prog, '-c', '-C', 'case_nobmp.yaml', 'FOO')
+ rc, out, err = runprog(prog, '-c', 'case_nobmp.yaml', 'FOO')
self.assertNotEqual(0, rc)
self.assertTrue(err.count("No such file or directory"))
def testInvalidBmp(self):
"""A .bmp file that isn't really a BMP should fail."""
- rc, out, err = runprog(prog, '-c', '-C', 'case_badbmp.yaml', 'FOO')
+ rc, out, err = runprog(prog, '-c', 'case_badbmp.yaml', 'FOO')
self.assertNotEqual(0, rc)
self.assertTrue(err.count("Unsupported image format"))

Powered by Google App Engine
This is Rietveld 408576698