Issue 6482001: New commandline args are clearer, and prepare for compression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6482001: New commandline args are clearer, and prepare for compression. (Closed)

Created:
9 years, 10 months ago by Bill Richardson

Modified:
9 years, 6 months ago

Reviewers:
Randall Spangler

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
http://git.chromium.org/git/vboot_reference.git@master

Visibility:
Public.

Description

New commandline args are clearer, and prepare for compression. BUG=chromium-os:11488 TEST=none Change-Id: I6ee493037da5746d2db6e840ac6590dd12f37cfe Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=794d4d4

Patch Set 1 #

Patch Set 2 : Move bmpblk_util.h out of firmware/include #

Total comments: 3

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+228 lines, -66 lines)			Patch
M	firmware/include/bmpblk_header.h	View		2 chunks	+2 lines, -1 line	1 comment	Download
M	tests/bitmaps/TestBmpBlock.py	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	utility/Makefile	View		1 chunk	+8 lines, -2 lines	0 comments	Download
A	utility/bmpblk_util.c	View		1 chunk	+101 lines, -0 lines	1 comment	Download
M	utility/bmpblk_utility.cc	View		2 chunks	+100 lines, -60 lines	1 comment	Download
A	utility/include/bmpblk_util.h	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Randall Spangler

9 years, 10 months ago (2011-02-10 21:45:10 UTC) #3

LGTM with some suggestions

(Since this is part 1 of a series of CLs, can address those in follow-on CLs if
you've already got part 2 queued up)

http://codereview.chromium.org/6482001/diff/8/firmware/include/bmpblk_header.h
File firmware/include/bmpblk_header.h (right):

http://codereview.chromium.org/6482001/diff/8/firmware/include/bmpblk_header....
firmware/include/bmpblk_header.h:121: MAX_COMPRESS,
COMPRESS_MAX, for consistency?

http://codereview.chromium.org/6482001/diff/8/utility/bmpblk_util.c
File utility/bmpblk_util.c (right):

http://codereview.chromium.org/6482001/diff/8/utility/bmpblk_util.c#newcode18
utility/bmpblk_util.c:18: static void *read_entire_file(const char *filename,
size_t *length) {
Could just link with HOSTLIB and use ReadFile().

http://codereview.chromium.org/6482001/diff/8/utility/bmpblk_utility.cc
File utility/bmpblk_utility.cc (right):

http://codereview.chromium.org/6482001/diff/8/utility/bmpblk_utility.cc#newco...
utility/bmpblk_utility.cc:498: "To create a new BMPBLOCK file:\n"
To create a new BMPBLOCK file using config from YAML file:

Expand Messages | Collapse Messages