Bypass JS accessors when building error array.

Bypass JS accessors when building error array.

In the presence of JS accessors for elements on Object.prototype JSArray::SetFastElement
may throw or its behaviour can be altered.  Instead operate on plain FixedArrays and
turn them into JSArry later.

BUG=v8:1130
TEST=test/mjsunit/regress/regress-1130.js

Committed: http://code.google.com/p/v8/source/detail?r=6730

[antonm, 2011-02-09 20:11:00]

Lasse,

may you have a look?

[Lasse Reichstein, 2011-02-10 14:26:18]

LGTM

http://codereview.chromium.org/6481001/diff/1/src/parser.cc
File src/parser.cc (right):

http://codereview.chromium.org/6481001/diff/1/src/parser.cc#newcode3934
src/parser.cc:3934: 
Nice and simple way of avoiding setters!

http://codereview.chromium.org/6481001/diff/1/test/mjsunit/regress/regress-11...
File test/mjsunit/regress/regress-1130.js (right):

http://codereview.chromium.org/6481001/diff/1/test/mjsunit/regress/regress-11...
test/mjsunit/regress/regress-1130.js:35: eval("(function() { const x; var x
})")();
To ensure that an exception is thrown, add an assertUnreachable() here, after
the eval.

http://codereview.chromium.org/6481001/diff/1/test/mjsunit/regress/regress-11...
test/mjsunit/regress/regress-1130.js:37: exception = e;
Then move the typecheck inside the catch, and drop the "exception" variable.

[antonm, 2011-02-10 15:01:54]

Thanks a lot for review, Lasse

http://codereview.chromium.org/6481001/diff/1/test/mjsunit/regress/regress-11...
File test/mjsunit/regress/regress-1130.js (right):

http://codereview.chromium.org/6481001/diff/1/test/mjsunit/regress/regress-11...
test/mjsunit/regress/regress-1130.js:35: eval("(function() { const x; var x
})")();
On 2011/02/10 14:26:18, Lasse Reichstein wrote:
> To ensure that an exception is thrown, add an assertUnreachable() here, after
> the eval.

Done.

http://codereview.chromium.org/6481001/diff/1/test/mjsunit/regress/regress-11...
test/mjsunit/regress/regress-1130.js:37: exception = e;
On 2011/02/10 14:26:18, Lasse Reichstein wrote:
> Then move the typecheck inside the catch, and drop the "exception" variable.

Done.