Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1377)

Unified Diff: chrome/browser/download/save_file_manager.cc

Issue 6480079: DownloadFile no longer keeps track of whether or not the final rename has occurred. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed nits. Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_manager_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/save_file_manager.cc
diff --git a/chrome/browser/download/save_file_manager.cc b/chrome/browser/download/save_file_manager.cc
index c18dd3f9a8ba91d8146b552ed65c492523048112..62b4ba1c2ef4f5283f450f6e198ad069b3be6f09 100644
--- a/chrome/browser/download/save_file_manager.cc
+++ b/chrome/browser/download/save_file_manager.cc
@@ -432,7 +432,6 @@ void SaveFileManager::SaveLocalFile(const GURL& original_file_url,
SaveFile* save_file = LookupSaveFile(save_id);
if (!save_file)
return;
- DCHECK(!save_file->path_renamed());
// If it has finished, just return.
if (!save_file->in_progress())
return;
@@ -490,7 +489,7 @@ void SaveFileManager::RenameAllFiles(
if (it != save_file_map_.end()) {
SaveFile* save_file = it->second;
DCHECK(!save_file->in_progress());
- save_file->Rename(i->second, true);
+ save_file->Rename(i->second);
delete save_file;
save_file_map_.erase(it);
}
« no previous file with comments | « chrome/browser/download/download_manager_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698