Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: chrome/browser/download/base_file.h

Issue 6480079: DownloadFile no longer keeps track of whether or not the final rename has occurred. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed nits. Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/download/base_file.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/base_file.h
diff --git a/chrome/browser/download/base_file.h b/chrome/browser/download/base_file.h
index 2dfaf14e1b05743f9c8de23ca5c4a8a8c3afd6f9..cf4bb24aa37944a024f558c96e1124610578fa15 100644
--- a/chrome/browser/download/base_file.h
+++ b/chrome/browser/download/base_file.h
@@ -40,9 +40,7 @@ class BaseFile {
bool AppendDataToFile(const char* data, size_t data_len);
// Rename the download file. Returns true on success.
- // |path_renamed_| is set to true only if |is_final_rename| is true.
- // Marked virtual for testing.
- virtual bool Rename(const FilePath& full_path, bool is_final_rename);
+ virtual bool Rename(const FilePath& full_path);
// Abort the download and automatically close the file.
void Cancel();
@@ -54,7 +52,6 @@ class BaseFile {
void AnnotateWithSourceInformation();
FilePath full_path() const { return full_path_; }
- bool path_renamed() const { return path_renamed_; }
bool in_progress() const { return file_stream_ != NULL; }
int64 bytes_so_far() const { return bytes_so_far_; }
@@ -71,9 +68,6 @@ class BaseFile {
// Full path to the file including the file name.
FilePath full_path_;
- // Whether the download is still using its initial temporary path.
- bool path_renamed_;
-
private:
static const size_t kSha256HashLen = 32;
« no previous file with comments | « no previous file | chrome/browser/download/base_file.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698