Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 6480068: Fix wrong assert in ia32 deoptimizer.... (Closed)

Created:
9 years, 10 months ago by Rico
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix wrong assert in ia32 deoptimizer. In revision 6795 I introduced an assertion in the deoptimizer that was wrong. We check that curr_address - prev_address > patch_size(), but prev_address is actually the address right after the last patched call, so we just need to be larger than or equal to prev_address. Committed: http://code.google.com/p/v8/source/detail?r=6797

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/ia32/deoptimizer-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Rico
9 years, 10 months ago (2011-02-15 16:10:21 UTC) #1
Søren Thygesen Gjesse
9 years, 10 months ago (2011-02-15 16:11:47 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698